Added gflags switches: duration, tests, save, out.

Added gflags switches: duration, tests, save, out.
Added saving images after a testcase is finished.
Updated power_Draw control file.

Checking against golden images will be done outside from a python script.

[piman, 2010-06-14 20:29:04]

http://codereview.chromium.org/2794002/diff/1/5
File client/deps/glbench/src/main.cc (right):

http://codereview.chromium.org/2794002/diff/1/5#newcode22
client/deps/glbench/src/main.cc:22: DEFINE_string(tests, "", "colon-separated
list of tests to run; all tests if omitted");
80 chars

http://codereview.chromium.org/2794002/diff/1/5#newcode32
client/deps/glbench/src/main.cc:32: i != enabled_tests.end(); i++) {
i++ -> ++i

http://codereview.chromium.org/2794002/diff/1/8
File client/deps/glbench/src/testbase.cc (right):

http://codereview.chromium.org/2794002/diff/1/8#newcode9
client/deps/glbench/src/testbase.cc:9: #include <unistd.h>
I don't think you need fcntl.h or sys/mman.h in this file (maybe not even
unistd.h)

http://codereview.chromium.org/2794002/diff/1/8#newcode84
client/deps/glbench/src/testbase.cc:84: file_util::WriteFile(filename,
pixels.get(), size);
I think it would be useful to save the images directly as png. It's about 3
lines of code if you use cairo, see the code in window_manager/screenshot.cc

[Alexey Marinichev, 2010-06-14 21:04:18]

http://codereview.chromium.org/2794002/diff/1/5
File client/deps/glbench/src/main.cc (right):

http://codereview.chromium.org/2794002/diff/1/5#newcode22
client/deps/glbench/src/main.cc:22: DEFINE_string(tests, "", "colon-separated
list of tests to run; all tests if omitted");
On 2010/06/14 20:29:04, piman wrote:
> 80 chars

Done.

http://codereview.chromium.org/2794002/diff/1/5#newcode32
client/deps/glbench/src/main.cc:32: i != enabled_tests.end(); i++) {
On 2010/06/14 20:29:04, piman wrote:
> i++ -> ++i

Sigh...  Done.

http://codereview.chromium.org/2794002/diff/1/8
File client/deps/glbench/src/testbase.cc (right):

http://codereview.chromium.org/2794002/diff/1/8#newcode9
client/deps/glbench/src/testbase.cc:9: #include <unistd.h>
On 2010/06/14 20:29:04, piman wrote:
> I don't think you need fcntl.h or sys/mman.h in this file (maybe not even
> unistd.h)

Done.

http://codereview.chromium.org/2794002/diff/1/8#newcode84
client/deps/glbench/src/testbase.cc:84: file_util::WriteFile(filename,
pixels.get(), size);
On 2010/06/14 20:29:04, piman wrote:
> I think it would be useful to save the images directly as png. It's about 3
> lines of code if you use cairo, see the code in window_manager/screenshot.cc

I am planning to use checksums to compare images against golden.  Checksums are
more reliable on raw files.

Golden images will be stored as png.  Converting is easy using imagemagick.

[piman, 2010-06-14 21:56:26]

LGTM. ok for raws for now, but it'd be useful to save the pngs in case of errors
so that it can be inspected for visual differences.

http://codereview.chromium.org/2794002/diff/1/8
File client/deps/glbench/src/testbase.cc (right):

http://codereview.chromium.org/2794002/diff/1/8#newcode84
client/deps/glbench/src/testbase.cc:84: file_util::WriteFile(filename,
pixels.get(), size);
On 2010/06/14 21:04:18, Alexey Marinichev wrote:
> On 2010/06/14 20:29:04, piman wrote:
> > I think it would be useful to save the images directly as png. It's about 3
> > lines of code if you use cairo, see the code in window_manager/screenshot.cc
> 
> I am planning to use checksums to compare images against golden.  Checksums
are
> more reliable on raw files.

I see.

> Golden images will be stored as png.  Converting is easy using imagemagick.

... if you know the exact dimensions of the image.

[Alexey Marinichev, 2010-06-14 22:17:56]

On 2010/06/14 21:56:26, piman wrote:
> LGTM. ok for raws for now, but it'd be useful to save the pngs in case of
errors
> so that it can be inspected for visual differences.
> 
> http://codereview.chromium.org/2794002/diff/1/8
> File client/deps/glbench/src/testbase.cc (right):
> 
> http://codereview.chromium.org/2794002/diff/1/8#newcode84
> client/deps/glbench/src/testbase.cc:84: file_util::WriteFile(filename,
> pixels.get(), size);
> On 2010/06/14 21:04:18, Alexey Marinichev wrote:
> > On 2010/06/14 20:29:04, piman wrote:
> > > I think it would be useful to save the images directly as png. It's about
3
> > > lines of code if you use cairo, see the code in
window_manager/screenshot.cc
> > 
> > I am planning to use checksums to compare images against golden.  Checksums
> are
> > more reliable on raw files.
> 
> I see.
> 
> > Golden images will be stored as png.  Converting is easy using imagemagick.
> 
> ... if you know the exact dimensions of the image.

Converting from png doesn't need dimensions -- so no external knowledge would be
required for visual comparisons.