Notification balloons don't want the WS_EX_LAYOUTRTL style flag, since the di...

chrome/browser/views/notifications/balloon_view.cc

Index: chrome/browser/views/notifications/balloon_view.cc
===================================================================
--- chrome/browser/views/notifications/balloon_view.cc	(revision 48993)
+++ chrome/browser/views/notifications/balloon_view.cc	(working copy)
@@ -296,13 +296,16 @@
   //
   // We carefully keep these two windows in sync to present the illusion of
   // one window to the user.
+  //
+  // We don't let the OS manage the RTL layout of these widgets, because
+  // this code is already taking care of correctly reversing the layout.

[xji, 2010/06/10 19:14:21]

Is the reason "because HTML content layout is determined by directionality in
HTML itself"? I am afraid that "this code is already taking care of correctly
reversing the layout" mislead people thinking the HTML content is mirrored in
someway. Or I mis-understood?

   gfx::Rect contents_rect = GetContentsRectangle();
   html_contents_.reset(new BalloonViewHost(balloon));
   html_contents_->SetPreferredSize(gfx::Size(10000, 10000));
-
   html_container_ = Widget::CreatePopupWidget(Widget::NotTransparent,
                                               Widget::AcceptEvents,
-                                              Widget::DeleteOnDestroy);
+                                              Widget::DeleteOnDestroy,
+                                              Widget::DontMirrorOriginInRTL);
   html_container_->SetAlwaysOnTop(true);
   html_container_->Init(NULL, contents_rect);
   html_container_->SetContentsView(html_contents_->view());
@@ -310,7 +313,8 @@
   gfx::Rect balloon_rect(x(), y(), GetTotalWidth(), GetTotalHeight());
   frame_container_ = Widget::CreatePopupWidget(Widget::Transparent,
                                                Widget::AcceptEvents,
-                                               Widget::DeleteOnDestroy);
+                                               Widget::DeleteOnDestroy,
+                                               Widget::DontMirrorOriginInRTL);
   frame_container_->SetWidgetDelegate(this);
   frame_container_->SetAlwaysOnTop(true);
   frame_container_->Init(NULL, balloon_rect);