Notification balloons don't want the WS_EX_LAYOUTRTL style flag, since the di...

chrome/browser/views/notifications/balloon_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/notifications/balloon_view.h"
 
 #include <vector>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 278 matching lines @@
   // * The contents is an html window which cannot be a
   //   layered window (because it may have child windows for instance).
   // * The frame is a layered window so that we can have nicely rounded
   //   corners using alpha blending (and we may do other alpha blending
   //   effects).
   // Unfortunately, layered windows cannot have child windows. (Well, they can
   // but the child windows don't render).
   //
   // We carefully keep these two windows in sync to present the illusion of
   // one window to the user.
+  //
+  // We don't let the OS manage the RTL layout of these widgets, because
+  // this code is already taking care of correctly reversing the layout.

[xji, 2010/06/10 19:14:21]

Is the reason "because HTML content layout is determined by directionality in
HTML itself"? I am afraid that "this code is already taking care of correctly
reversing the layout" mislead people thinking the HTML content is mirrored in
someway. Or I mis-understood?

   gfx::Rect contents_rect = GetContentsRectangle();
   html_contents_.reset(new BalloonViewHost(balloon));
   html_contents_->SetPreferredSize(gfx::Size(10000, 10000));
-
   html_container_ = Widget::CreatePopupWidget(Widget::NotTransparent,
                                               Widget::AcceptEvents,
-                                              Widget::DeleteOnDestroy);
+                                              Widget::DeleteOnDestroy,
+                                              Widget::DontMirrorOriginInRTL);
   html_container_->SetAlwaysOnTop(true);
   html_container_->Init(NULL, contents_rect);
   html_container_->SetContentsView(html_contents_->view());
 
   gfx::Rect balloon_rect(x(), y(), GetTotalWidth(), GetTotalHeight());
   frame_container_ = Widget::CreatePopupWidget(Widget::Transparent,
                                                Widget::AcceptEvents,
-                                               Widget::DeleteOnDestroy);
+                                               Widget::DeleteOnDestroy,
+                                               Widget::DontMirrorOriginInRTL);
   frame_container_->SetWidgetDelegate(this);
   frame_container_->SetAlwaysOnTop(true);
   frame_container_->Init(NULL, balloon_rect);
   frame_container_->SetContentsView(this);
   frame_container_->MoveAbove(html_container_);
 
   close_button_->SetImage(views::CustomButton::BS_NORMAL,
       rb.GetBitmapNamed(IDR_BALLOON_CLOSE));
   close_button_->SetImage(views::CustomButton::BS_HOT,
       rb.GetBitmapNamed(IDR_BALLOON_CLOSE_HOVER));
@@ skipping 185 matching lines @@
     NOTREACHED();
     return;
   }
 
   // If the renderer process attached to this balloon is disconnected
   // (e.g., because of a crash), we want to close the balloon.
   notification_registrar_.Remove(this,
       NotificationType::NOTIFY_BALLOON_DISCONNECTED, Source<Balloon>(balloon_));
   Close(false);
 }