Issue 2791001: Take Keystone keys out of the framework's Info.plist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2791001: Take Keystone keys out of the framework's Info.plist (Closed)

Created:
10 years, 6 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Take Keystone keys out of the framework's Info.plist. They now live only in the outer application's Info.plist. This ensures that the framework and other contents of the versioned directory can be bit-for-bit identical for a given version, regardless of configured Keystone channel. This will enable binary diff updates, because they will not need knowledge of the channel a user is upgrading from. BUG=45017 TEST=Keystone still functions properly, channel still shows up in the about window and about:version of official builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49334

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -21 lines)			Patch
M	chrome/browser/cocoa/keystone_glue.mm	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/platform_util_mac.mm	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages