Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: chrome/chrome_dll.gypi

Issue 2791001: Take Keystone keys out of the framework's Info.plist (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_dll.gypi
===================================================================
--- chrome/chrome_dll.gypi (revision 49261)
+++ chrome/chrome_dll.gypi (working copy)
@@ -391,14 +391,15 @@
{
# Modify the Info.plist as needed. The script explains why
# this is needed. This is also done in the chrome target.
- # The framework needs the Breakpad and Keystone keys if
- # those features are enabled. It doesn't currently use the
- # Subversion keys for anything, but this seems like a really
- # good place to store them.
+ # The framework needs the Breakpad keys if this feature is
+ # enabled. It does not need the Keystone keys; these always
+ # come from the outer application bundle. The framework
+ # doesn't currently use the Subversion keys for anything,
+ # but this seems like a really good place to store them.
'postbuild_name': 'Tweak Info.plist',
'action': ['<(tweak_info_plist_path)',
'-b<(mac_breakpad)',
- '-k<(mac_keystone)',
+ '-k0',
'-s1',
'<(branding)',
'<(mac_bundle_id)'],
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698