Issue 279006: Fix extension canceling; the CFUserNotification functionality gets a bit weir...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279006: Fix extension canceling; the CFUserNotification functionality gets a bit weir... (Closed)

Created:
11 years, 2 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix extension canceling; the CFUserNotification functionality gets a bit weird. BUG=http://crbug.com/23405 TEST=try to cancel extension load; it should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29046

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

		Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)
	M	chrome/browser/extensions/extension_install_ui.cc	View	2 chunks	+3 lines, -2 lines	1 comment

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 2 months ago (2009-10-14 22:32:30 UTC) #2

lgtm

http://codereview.chromium.org/279006/diff/1/2
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/279006/diff/1/2#newcode167
Line 167: if (kCFUserNotificationAlternateResponse == response) {
We don't usually do (constant == variable), we usually write in English.  I'm
aware of why this might be better, but it's still harder to read.  LG if you
like it this way though.

Expand Messages | Collapse Messages