Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 279006: Fix extension canceling; the CFUserNotification functionality gets a bit weir... (Closed)

Created:
11 years, 2 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix extension canceling; the CFUserNotification functionality gets a bit weird. BUG=http://crbug.com/23405 TEST=try to cancel extension load; it should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29046

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +3 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
11 years, 2 months ago (2009-10-14 22:07:43 UTC) #1
Mark Mentovai
11 years, 2 months ago (2009-10-14 22:32:30 UTC) #2
lgtm

http://codereview.chromium.org/279006/diff/1/2
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/279006/diff/1/2#newcode167
Line 167: if (kCFUserNotificationAlternateResponse == response) {
We don't usually do (constant == variable), we usually write in English.  I'm
aware of why this might be better, but it's still harder to read.  LG if you
like it this way though.

Powered by Google App Engine
This is Rietveld 408576698