Fix extension canceling; the CFUserNotification functionality gets a bit weir...

chrome/browser/extensions/extension_install_ui.cc

Index: chrome/browser/extensions/extension_install_ui.cc
===================================================================
--- chrome/browser/extensions/extension_install_ui.cc	(revision 28991)
+++ chrome/browser/extensions/extension_install_ui.cc	(working copy)
@@ -154,7 +154,7 @@
       l10n_util::GetString(IDS_EXTENSION_PROMPT_CANCEL_BUTTON)));
 
   CFOptionFlags response;
-  if (kCFUserNotificationAlternateResponse == CFUserNotificationDisplayAlert(
+  CFUserNotificationDisplayAlert(
       0, kCFUserNotificationCautionAlertLevel,
       NULL, // TODO(port): show the install_icon instead of a default.
       NULL, NULL, // Sound URL, localization URL.
@@ -163,7 +163,8 @@
       NULL, // Default button.
       confirm_cancel,
       NULL, // Other button.
-      &response)) {
+      &response);
+  if (kCFUserNotificationAlternateResponse == response) {

[Mark Mentovai, 2009/10/14 22:32:30]

We don't usually do (constant == variable), we usually write in English.  I'm
aware of why this might be better, but it's still harder to read.  LG if you
like it this way though.

     delegate->AbortInstall();
   } else {
     delegate->ContinueInstall();