Take 2 at working around a multipart crash

Take 2 at working around a multipart crash

The work around is to be more aggressive about sending
multipart data before we have a response header.  We used
to buffer a response until we had the full frame.

This avoids a crash in webcore by behaving more like
CFNetwork.  It also makes us behave more like Gecko,
which is probably good for compat.

The original patch (r47599) broke plugins on Windows because
it was depending on the assumption that we would send data
as one big chunk.  Now that we send data as multiple chunks,
we need to update the data offset being sent to the plugin.

BUG=30880
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49355

[tony, 2010-06-09 09:17:05]

The multipart code was r+ in the original patch by darin.

http://codereview.chromium.org/2070007

[jam, 2010-06-09 21:21:32]

lgtm

http://codereview.chromium.org/2787002/diff/1/4
File webkit/glue/plugins/webplugin_impl.cc (right):

http://codereview.chromium.org/2787002/diff/1/4#newcode112
webkit/glue/plugins/webplugin_impl.cc:112: byte_range_lower_bound_+= data_size;
nit missing space

[ananta, 2010-06-09 21:23:55]

LGTM. Please verify that Acrobat reader continues to render byte range optimized
PDF files correctly

[tony, 2010-06-10 01:20:56]

On 2010/06/09 21:23:55, ananta wrote:
> LGTM. Please verify that Acrobat reader continues to render byte range
optimized
> PDF files correctly

Are there some manual tests I can run other than loading PDF files listed in
http://code.google.com/p/chromium/issues/detail?id=44595 ? They seem to work
after clearing the cache with this patch (and I was able to repro the hang
without the webplugin_impl change).

[iyengar, 2010-06-10 01:23:09]

An example is
https://docs.google.com/a/google.com/viewer?url=http://www.bankofengland.co.u...
.

-Ananta

On Wed, Jun 9, 2010 at 6:20 PM, <tony@chromium.org> wrote:

> On 2010/06/09 21:23:55, ananta wrote:
>
>> LGTM. Please verify that Acrobat reader continues to render byte range
>>
> optimized
>
>> PDF files correctly
>>
>
> Are there some manual tests I can run other than loading PDF files listed
> in
> http://code.google.com/p/chromium/issues/detail?id=44595 ? They seem to
> work
> after clearing the cache with this patch (and I was able to repro the hang
> without the webplugin_impl change).
>
>
> http://codereview.chromium.org/2787002/show
>

[tony, 2010-06-10 02:13:39]

On 2010/06/10 01:23:09, iyengar_google.com wrote:
> An example is
>
https://docs.google.com/a/google.com/viewer?url=http://www.bankofengland.co.u...

You mean without the docs.google.com part, right?  Anyway, it loads for me both
in docs and if I try to load the PDF directly.