Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Issue 2070007: Work around a multipart crash caused by sending (Closed)

Created:
10 years, 7 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Work around a multipart crash caused by sending a response header immediately after sending data. The work around is to be more aggressive about sending multipart data before we have a response header. We used to buffer a response until we had the full frame. This avoids a crash in webcore by behaving more like CFNetwork. It also makes us behave more like Gecko, which is probably good for compat. BUG=30880 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47599

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M webkit/glue/multipart_response_delegate.cc View 1 chunk +12 lines, -0 lines 1 comment Download
M webkit/glue/multipart_response_delegate_unittest.cc View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
10 years, 7 months ago (2010-05-18 04:39:42 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/2070007/diff/1/2 File webkit/glue/multipart_response_delegate.cc (right): http://codereview.chromium.org/2070007/diff/1/2#newcode160 webkit/glue/multipart_response_delegate.cc:160: send_length = data_.length(); nit: indentation
10 years, 7 months ago (2010-05-18 15:46:10 UTC) #2
tony
10 years, 7 months ago (2010-05-18 23:52:04 UTC) #3
On 2010/05/18 15:46:10, darin wrote:
> http://codereview.chromium.org/2070007/diff/1/2
> File webkit/glue/multipart_response_delegate.cc (right):
> 
> http://codereview.chromium.org/2070007/diff/1/2#newcode160
> webkit/glue/multipart_response_delegate.cc:160: send_length = data_.length();
> nit: indentation

Heh, I've been writing too much WebKit code.  Fixed and submitting.

Powered by Google App Engine
This is Rietveld 408576698