Remove duplicated code in AcceleratedSurface using PbufferGLContext instead....

Remove duplicated code in AcceleratedSurface using PbufferGLContext instead.
This also fixes a crash caused by the OpenGL bindings not being initialized.

BUG=46286
TEST=flash plugin 10.1 works again in both mac 10.5 and 10.6


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49836

[apatrick, 2010-06-12 17:22:09]

Awesome! I will test it, run it through the trybots and commit the patch if all
goes well. I will make one change to the whitespace. It is otherwise compliant
with our style guide.

Thanks for fixing it so fast and thanks for removing the redundancy.

LGTM

http://codereview.chromium.org/2782006/diff/1/4
File app/surface/accelerated_surface_mac.cc (right):

http://codereview.chromium.org/2782006/diff/1/4#newcode235
app/surface/accelerated_surface_mac.cc:235: gl_context_->GetHandle()),
This does not conform to our style guide. I will change it.

[Ken Russell (switch to Gerrit), 2010-06-14 21:20:01]

This is a good cleanup; thanks for doing it. There is a problem with Pepper 3D
plugins after this refactoring; I'm investigating it now and will follow up
shortly.

[Ken Russell (switch to Gerrit), 2010-06-14 22:30:14]

LGTM after the issue below is fixed.

Do you need help landing this fix? Or are you a Chromium committer?

http://codereview.chromium.org/2782006/diff/1/4
File app/surface/accelerated_surface_mac.cc (right):

http://codereview.chromium.org/2782006/diff/1/4#newcode53
app/surface/accelerated_surface_mac.cc:53: DCHECK(gl_context_->IsCurrent());
This DCHECK needs to be removed; the way the AcceleratedSurface works we might
call this while another, external, GL context is current. See the comment a few
lines below. With this change both Flash 10.1 and Pepper 3D plugins are working
on the Mac.

[vt, 2010-06-15 16:02:21]

On 2010/06/14 22:30:14, kbr wrote:
> Do you need help landing this fix? Or are you a Chromium committer?

Not a committer, so I'll need someone to commit this.

[vt, 2010-06-15 16:02:29]

http://codereview.chromium.org/2782006/diff/1/4
File app/surface/accelerated_surface_mac.cc (right):

http://codereview.chromium.org/2782006/diff/1/4#newcode53
app/surface/accelerated_surface_mac.cc:53: DCHECK(gl_context_->IsCurrent());
On 2010/06/14 22:30:14, kbr wrote:
> This DCHECK needs to be removed; the way the AcceleratedSurface works we might
> call this while another, external, GL context is current. See the comment a
few
> lines below. With this change both Flash 10.1 and Pepper 3D plugins are
working
> on the Mac.
> 

Didn't catch the comment. Fixed.

[Ken Russell (switch to Gerrit), 2010-06-15 22:04:51]

Committed per above. Thanks for your contribution.