Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 278015: Allow specifying multiple bots with git-try.... (Closed)

Created:
11 years, 2 months ago by mattm
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Allow specifying multiple bots with git-try. BUG=none TEST=git-try -b linux -b linux_view

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M git-try View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mattm
11 years, 2 months ago (2009-10-15 02:29:27 UTC) #1
Evan Martin
I think you can do -b foo1,foo2
11 years, 2 months ago (2009-10-15 06:26:25 UTC) #2
M-A Ruel
Evan is right but I don't mind, lgtm.
11 years, 2 months ago (2009-10-15 13:17:42 UTC) #3
Evan Martin
% git try Traceback (most recent call last): File "/work/chrome/depot_tools/git-try", line 249, in <module> for ...
11 years, 2 months ago (2009-10-15 23:37:52 UTC) #4
M-A Ruel
On 2009/10/15 23:37:52, Evan Martin wrote: > % git try > Traceback (most recent call ...
11 years, 2 months ago (2009-10-15 23:41:41 UTC) #5
mattm
11 years, 2 months ago (2009-10-16 00:04:12 UTC) #6
shess has a cl to fix it http://codereview.chromium.org/276053/show

On Thu, Oct 15, 2009 at 16:41,  <maruel@chromium.org> wrote:
> On 2009/10/15 23:37:52, Evan Martin wrote:
>>
>> % git try
>> Traceback (most recent call last):
>> =A0 File "/work/chrome/depot_tools/git-try", line 249, in <module>
>> =A0 =A0 for bot in options.bot:
>> TypeError: 'NoneType' object is not iterable
>
> default=3D[]
>
> I wondered about that. I thought it was tested and thus wasn't necessary.
>
> http://codereview.chromium.org/278015
>

Powered by Google App Engine
This is Rietveld 408576698