Make the reload button respond to middle-clicks like back/forward/home alread...

Make the reload button respond to middle-clicks like back/forward/home already do.

This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward.

BUG=none
TEST=Middle-click reload.  It should reload the page in a new background tab.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49350

[Peter Kasting, 2010-06-09 21:14:30]

sky: Windows + cross-platform
estade: GTK
shess: Mac (please test that this works, as hand-editing .xibs scares me)

[Evan Stade, 2010-06-09 21:20:35]

gtk lg

[sky, 2010-06-09 21:25:00]

http://codereview.chromium.org/2779011/diff/1/5
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2779011/diff/1/5#newcode1150
chrome/browser/browser.cc:1150: current_tab->controller().GoBack();
Should this be new_tab?

[Peter Kasting, 2010-06-09 21:34:10]

http://codereview.chromium.org/2779011/diff/1/5
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2779011/diff/1/5#newcode1150
chrome/browser/browser.cc:1150: current_tab->controller().GoBack();
On 2010/06/09 21:25:01, sky wrote:
> Should this be new_tab?

Yes, I think so.

[Scott Hess - ex-Googler, 2010-06-09 22:08:06]

Seems to work on Mac.

Note that Middle-click doesn't work on these buttons.  I'll go log a bug :-).

http://codereview.chromium.org/2779011/diff/12001/7008
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/2779011/diff/12001/7008#newcode946
chrome/browser/cocoa/browser_window_controller.mm:946: }
Command-r will not come to this function, so you can get rid of the if() and
leave the contents alone.  But ... since Command-click opens in a new tab, it
would seem to make sense to not Revert() in that case.  Except WRT the comment
below by -isMainWindow, which might mean that the test is too early.

[Did that all make sense?]

[Peter Kasting, 2010-06-09 22:41:40]

OK, new snap up that addresses all comments, fixes some bugs in location bar
resetting on GTK and Mac, and hopefully compiles.

[sky, 2010-06-09 22:45:05]

LGTM

[Scott Hess - ex-Googler, 2010-06-09 23:07:50]

lgtm

[Evan Stade, 2010-06-09 23:11:45]

still lgtm