Make the reload button respond to middle-clicks like back/forward/home alread...

chrome/browser/cocoa/browser_window_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/browser_window_controller.h"
 
 #include <Carbon/Carbon.h>
 
 #include "app/l10n_util_mac.h"
 #include "base/mac_util.h"
@@ skipping 900 matching lines @@
   // Identify the actual BWC to which the command should be dispatched. It might
   // belong to a background window, yet this controller gets it because it is
   // the foreground window's controller and thus in the responder chain. Some
   // senders don't have this problem (for example, menus only operate on the
   // foreground window), so this is only an issue for senders that are part of
   // windows.
   BrowserWindowController* targetController = self;
   if ([sender respondsToSelector:@selector(window)])
     targetController = [[sender window] windowController];
   DCHECK([targetController isKindOfClass:[BrowserWindowController class]]);
-  NSInteger tag = [sender tag];
-  switch (tag) {
-    case IDC_RELOAD:
-      if ([sender isKindOfClass:[NSButton class]]) {
-        // We revert the bar when the reload button is pressed, but don't when
-        // Command+r is pressed (Issue 15464). Unlike the event handler function
-        // for Windows (ToolbarView::ButtonPressed()), this function handles
-        // both reload button press event and Command+r press event. Thus the
-        // 'isKindofClass' check is necessary.
-        [targetController locationBarBridge]->Revert();
-      }
-      NSUInteger modifierFlags = [[NSApp currentEvent] modifierFlags];
-      if (modifierFlags & NSShiftKeyMask) {
-        tag = IDC_RELOAD_IGNORING_CACHE;
-      }
-      break;
-  }
   DCHECK(targetController->browser_.get());
-  targetController->browser_->ExecuteCommand(tag);
+  targetController->browser_->ExecuteCommand([sender tag]);
 }
 
 // Same as |-commandDispatch:|, but executes commands using a disposition
 // determined by the key flags. If the window is in the background and the
 // command key is down, ignore the command key, but process any other modifiers.
 - (void)commandDispatchUsingKeyModifiers:(id)sender {
   DCHECK(sender);
   // See comment above for why we do this.
   BrowserWindowController* targetController = self;
   if ([sender respondsToSelector:@selector(window)])
     targetController = [[sender window] windowController];
   DCHECK([targetController isKindOfClass:[BrowserWindowController class]]);
-  NSInteger tag = [sender tag];
-  DCHECK(targetController->browser_.get());
+  NSInteger command = [sender tag];
   NSUInteger modifierFlags = [[NSApp currentEvent] modifierFlags];
+  if ((command == IDC_RELOAD) && (modifierFlags & NSShiftKeyMask)) {
+    command = IDC_RELOAD_IGNORING_CACHE;
+    // Mask off shift so it isn't interpreted as affecting the disposition
+    // below.
+    modifierFlags &= ~NSShiftKeyMask;
+  }
   if (![[sender window] isMainWindow]) {
     // Remove the command key from the flags, it means "keep the window in
     // the background" in this case.
     modifierFlags &= ~NSCommandKeyMask;
   }
-  targetController->browser_->ExecuteCommandWithDisposition(tag,
+  WindowOpenDisposition disposition =
       event_utils::WindowOpenDispositionFromNSEventWithFlags(
-          [NSApp currentEvent], modifierFlags));
+          [NSApp currentEvent], modifierFlags);
+  switch (command) {
+    case IDC_BACK:
+    case IDC_FORWARD:
+    case IDC_RELOAD:
+    case IDC_RELOAD_IGNORING_CACHE:
+      if (disposition == CURRENT_TAB) {
+        // Forcibly reset the location bar, since otherwise it won't discard any
+        // ongoing user edits, since it doesn't realize this is a user-initiated
+        // action.
+        [targetController locationBarBridge]->Revert();
+      }
+  }
+  DCHECK(targetController->browser_.get());
+  targetController->browser_->ExecuteCommandWithDisposition(command,
+                                                            disposition);
 }
 
 // Called when another part of the internal codebase needs to execute a
 // command.
 - (void)executeCommand:(int)command {
   if (browser_->command_updater()->IsCommandEnabled(command))
     browser_->ExecuteCommand(command);
 }
 
 // StatusBubble delegate method: tell the status bubble how far above the bottom
@@ skipping 884 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isNormalWindow {
   return browser_->type() == Browser::TYPE_NORMAL;
 }
 
 @end  // @implementation BrowserWindowController(WindowType)