Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4086)

Unified Diff: chrome/installer/util/google_update_settings.h

Issue 2773002: Fix problem whereby the "-full" magic value is removed from the "ap" value wh... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_update_settings.h
===================================================================
--- chrome/installer/util/google_update_settings.h (revision 49062)
+++ chrome/installer/util/google_update_settings.h (working copy)
@@ -83,6 +83,27 @@
// on success, channel contains one of "", "unknown", "dev" or "beta".
static bool GetChromeChannel(bool system_install, std::wstring* channel);
+ static void UpdateDiffInstallStatus(bool system_install,
+ bool incremental_install,
+ int install_return_code,
+ const std::wstring& product_guid);
+
+ // This method generates the new value for Google Update "ap" key for Chrome
+ // based on whether we are doing incremental install (or not) and whether
+ // the install succeeded.
+ // - If install worked, remove the magic string (if present).
+ // - If incremental installer failed, append a magic string (if
+ // not present already).
+ // - If full installer failed, still remove this magic
+ // string (if it is present already).
+ //
+ // diff_install: tells whether this is incremental install or not.
+ // install_return_code: if 0, means installation was successful.
+ // value: current value of Google Update "ap" key.
+ static std::wstring GetNewGoogleUpdateApKey(bool diff_install,
+ int install_return_code,
+ const std::wstring& value);
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(GoogleUpdateSettings);
};

Powered by Google App Engine
This is Rietveld 408576698