chrome/installer/setup/setup_main.cc - Issue 2773002: Fix problem whereby the "-full" magic value is removed from the "ap" value wh...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 2773002: Fix problem whereby the "-full" magic value is removed from the "ap" value wh... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/setup_main.cc

===================================================================

--- chrome/installer/setup/setup_main.cc (revision 49062)

+++ chrome/installer/setup/setup_main.cc (working copy)

@@ -742,7 +742,7 @@

// Note that we allow the status installer_util::UNINSTALL_REQUIRES_REBOOT

// to pass through, since this is only returned on uninstall which is never

// invoked directly by Google Update.

- dist->GetInstallReturnCode(install_status);

+ return_code = dist->GetInstallReturnCode(install_status);

huanr 2010/06/09 23:46:11 So this is a regression by r41322 3 months ago ht

robertshield 2010/06/10 00:30:30 Yes, it is a regression. I believe this could impa

}

LOG(INFO) << "Installation complete, returning: " << return_code;

« no previous file with comments | « no previous file | chrome/installer/util/chrome_frame_distribution.cc » ('j') | no next file with comments »