Issue 2767012: [Mac] Don't disable all menu items if there isn't a browser window open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2767012: [Mac] Don't disable all menu items if there isn't a browser window open. (Closed)

Created:
10 years, 6 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Don't disable all menu items if there isn't a browser window open. BUG=46355 TEST=Close all browser windows. New Tab, New Window, History and Bookmark menus, etc are enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49536

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/app_controller_mac.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

http://codereview.chromium.org/2767012/diff/1/2 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/2767012/diff/1/2#newcode583 chrome/browser/app_controller_mac.mm:583: return [NSApp modalWindow] == nil && (!browser || (browser ...

10 years, 6 months ago (2010-06-11 16:09:35 UTC) #2

Robert Sesek

10 years, 6 months ago (2010-06-11 16:22:00 UTC) #3

http://codereview.chromium.org/2767012/diff/1/2
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/2767012/diff/1/2#newcode583
chrome/browser/app_controller_mac.mm:583: return [NSApp modalWindow] == nil &&
(!browser || (browser &&
On 2010/06/11 16:09:35, Bernhard Bauer wrote:
> "browser &&" seems unnecessary after the previous check. Maybe you could
rewrite
> the whole thing to 
> 
> [NSApp modalWindow] == nil && !(browser &&
> [[browser->window()->GetNativeHandle() attachedSheet] isKindOfClass:[NSWindow
> class]])
> 
> Otherwise, LGTM!

I removed the browser&& (it was unnecessary), but I think that your other
suggestion is harder to mentally parse than:

&& (!browser || ![[browser->window()...

Expand Messages | Collapse Messages