chrome/browser/app_controller_mac.mm - Issue 2767012: [Mac] Don't disable all menu items if there isn't a browser window open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 2767012: [Mac] Don't disable all menu items if there isn't a browser window open. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: '' Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 84207622f81a824182d99d4384bd61a574ef678d..4fa46b6161bef32a50bb3c5197489e822a3e40f3 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -580,7 +580,7 @@ void RecordLastRunAppBundlePath() {

// dialogs that are window modal will block the browser.

- (BOOL)keyWindowIsNotModal {

Browser* browser = BrowserList::GetLastActive();

- return [NSApp modalWindow] == nil && (browser &&

+ return [NSApp modalWindow] == nil && (!browser ||

![[browser->window()->GetNativeHandle() attachedSheet]

isKindOfClass:[NSWindow class]]);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »