Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2765002: Automatically append FLAKY_ and FAILS_ prefixes to gtest_filters.... (Closed)

Created:
10 years, 6 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

[GTTF] Automatically append FLAKY_ and FAILS_ prefixes to gtest_filters. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49240

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M chrome/test/data/valgrind/ui_tests.gtest_linux.txt View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/valgrind/ui_tests.gtest_mac.txt View 1 3 chunks +12 lines, -12 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Timur Iskhodzhanov
10 years, 6 months ago (2010-06-09 08:47:41 UTC) #1
Paweł Hajdan Jr.
LGTM I've updated the commit message to include the GTTF prefix (because it'll be good ...
10 years, 6 months ago (2010-06-09 09:03:36 UTC) #2
Alexander Potapenko
10 years, 6 months ago (2010-06-09 09:09:20 UTC) #3
On 2010/06/09 09:03:36, Paweł Hajdan Jr. wrote:
> LGTM
> 
> I've updated the commit message to include the GTTF prefix (because it'll be
> good for Greener Tree, thanks!).

LGTM

Powered by Google App Engine
This is Rietveld 408576698