Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/valgrind/chrome_tests.py

Issue 2765002: Automatically append FLAKY_ and FAILS_ prefixes to gtest_filters.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/valgrind/ui_tests.gtest_mac.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
===================================================================
--- tools/valgrind/chrome_tests.py (revision 49171)
+++ tools/valgrind/chrome_tests.py (working copy)
@@ -180,7 +180,18 @@
if line.startswith("#") or line.startswith("//") or line.isspace():
continue
line = line.rstrip()
+ test_prefixes = ["FLAKY", "FAILS"]
+ for p in test_prefixes:
+ # Strip prefixes from the test names.
+ line = line.replace(".%s_" % p, ".")
+ # Exclude the original test name.
filters.append(line)
+ if line[-2:] != ".*":
+ # List all possible prefixes if line doesn't end with ".*".
+ for p in test_prefixes:
+ filters.append(line.replace(".", ".%s_" % p))
+ # Get rid of duplicates.
+ filters = set(filters)
gtest_filter = self._gtest_filter
if len(filters):
if gtest_filter:
« no previous file with comments | « chrome/test/data/valgrind/ui_tests.gtest_mac.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698