Issue 276034: Explicitly mark some platform/mac/accessibility tests as passing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276034: Explicitly mark some platform/mac/accessibility tests as passing... (Closed)

Created:
11 years, 2 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Explicitly mark some platform/mac/accessibility tests as passing TBR=ojan TEST=none BUG=10322 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29054

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

11 years, 2 months ago (2009-10-14 23:00:19 UTC) #2

LGTM!

On Wed, Oct 14, 2009 at 3:47 PM, <dglazkov@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Explicitly mark some platform/mac/accessibility tests as passing
>
> TBR=ojan
> TEST=none
> BUG=10322
>
>
> Please review this at http://codereview.chromium.org/276034
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 29046)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -1247,6 +1247,13 @@
>  BUG10322 : LayoutTests/accessibility/visible-elements.html = FAIL
>  BUG10322 : LayoutTests/accessibility/input-slider.html = FAIL
>  BUG10322 : LayoutTests/platform/mac/accessibility = FAIL
> +BUG10322 :
> LayoutTests/platform/mac/accessibility/aria-radiobutton-text.html = PASS
> +BUG10322 : LayoutTests/platform/mac/accessibility/aria-radiogroup.html =
> PASS
> +BUG10322 : LayoutTests/platform/mac/accessibility/aria-range.html = PASS
> +BUG10322 : LayoutTests/platform/mac/accessibility/aria-slider.html = PASS
> +BUG10322 : LayoutTests/platform/mac/accessibility/aria-spinbutton.html =
> PASS
> +BUG10322 : LayoutTests/platform/mac/accessibility/aria-toolbar.html = PASS
> +BUG10322 : LayoutTests/platform/mac/accessibility/table-updating.html =
> PASS
>  BUG10322 : LayoutTests/platform/win/accessibility = FAIL
>  // Introduced in http://trac.webkit.org/changeset/48368
>  BUG10322 SKIP :
> LayoutTests/platform/win/accessibility/scroll-to-anchor.html = FAIL
>
>
>

Expand Messages | Collapse Messages