Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2755007: Move the remainder of the installer-related files to chrome/installer/mac (Closed)

Created:
10 years, 6 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews, kuchhal, pam+watch_chromium.org
Visibility:
Public.

Description

Finish the job that r48732 started. Move the remainder of the installer-related files from chrome/tools/build/mac to chrome/installer/mac. BUG=45017 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49551

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1711 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/installer/mac/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/mac/keystone_install_test.sh View 1 3 chunks +6 lines, -14 lines 0 comments Download
A + chrome/installer/mac/pkg-dmg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/tools/build/mac/README.chromium View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/tools/build/mac/build_app_dmg View 1 chunk +1 line, -1 line 0 comments Download
chrome/tools/build/mac/keystone_install_test.sh View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/tools/build/mac/pkg-dmg View 1 chunk +0 lines, -1523 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
10 years, 6 months ago (2010-06-11 17:00:45 UTC) #1
TVL
lg http://codereview.chromium.org/2755007/diff/1/4 File chrome/installer/mac/keystone_install_test.sh (right): http://codereview.chromium.org/2755007/diff/1/4#newcode98 chrome/installer/mac/keystone_install_test.sh:98: mkdir -p "${RSRCDIR}" is this still needed? http://codereview.chromium.org/2755007/diff/1/4#newcode122 ...
10 years, 6 months ago (2010-06-11 17:14:29 UTC) #2
Mark Mentovai
http://codereview.chromium.org/2755007/diff/1/4 File chrome/installer/mac/keystone_install_test.sh (right): http://codereview.chromium.org/2755007/diff/1/4#newcode98 chrome/installer/mac/keystone_install_test.sh:98: mkdir -p "${RSRCDIR}" TVL wrote: > is this still ...
10 years, 6 months ago (2010-06-11 17:45:06 UTC) #3
TVL
10 years, 6 months ago (2010-06-11 17:49:45 UTC) #4
lg

Powered by Google App Engine
This is Rietveld 408576698