Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/renderer/extensions/extension_api_client_unittest.cc

Issue 2751004: Mark ExtensionAPIClientTest.CreateWindow as flaky on Windows... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/extension_api_client_unittest.cc
===================================================================
--- chrome/renderer/extensions/extension_api_client_unittest.cc (revision 48638)
+++ chrome/renderer/extensions/extension_api_client_unittest.cc (working copy)
@@ -213,7 +213,13 @@
"windows.getAll", "null");
}
-TEST_F(ExtensionAPIClientTest, CreateWindow) {
+// Flaky on Windows.
+#if defined(OS_WIN)
+#define MAYBE_CreateWindow FLAKY_CreateWindow
+#else
+#define MAYBE_CreateWindow CreateWindow
+#endif
+TEST_F(ExtensionAPIClientTest, MAYBE_CreateWindow) {
ExpectJsFail("chrome.windows.create({url: 1}, function(){});",
"Uncaught Error: Invalid value for argument 0. Property "
"'url': Expected 'string' but got 'integer'.");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698