Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/renderer/extensions/extension_api_client_unittest.cc

Issue 2751004: Mark ExtensionAPIClientTest.CreateWindow as flaky on Windows... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/json/json_reader.h" 6 #include "base/json/json_reader.h"
7 #include "base/json/json_writer.h" 7 #include "base/json/json_writer.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 ExpectJsPass("chrome.windows.getAll(null, function(){})", 206 ExpectJsPass("chrome.windows.getAll(null, function(){})",
207 "windows.getAll", "null"); 207 "windows.getAll", "null");
208 208
209 ExpectJsPass("chrome.windows.getAll({}, function(){})", 209 ExpectJsPass("chrome.windows.getAll({}, function(){})",
210 "windows.getAll", "{}"); 210 "windows.getAll", "{}");
211 211
212 ExpectJsPass("chrome.windows.getAll(undefined, function(){})", 212 ExpectJsPass("chrome.windows.getAll(undefined, function(){})",
213 "windows.getAll", "null"); 213 "windows.getAll", "null");
214 } 214 }
215 215
216 TEST_F(ExtensionAPIClientTest, CreateWindow) { 216 // Flaky on Windows.
217 #if defined(OS_WIN)
218 #define MAYBE_CreateWindow FLAKY_CreateWindow
219 #else
220 #define MAYBE_CreateWindow CreateWindow
221 #endif
222 TEST_F(ExtensionAPIClientTest, MAYBE_CreateWindow) {
217 ExpectJsFail("chrome.windows.create({url: 1}, function(){});", 223 ExpectJsFail("chrome.windows.create({url: 1}, function(){});",
218 "Uncaught Error: Invalid value for argument 0. Property " 224 "Uncaught Error: Invalid value for argument 0. Property "
219 "'url': Expected 'string' but got 'integer'."); 225 "'url': Expected 'string' but got 'integer'.");
220 ExpectJsFail("chrome.windows.create({left: 'foo'}, function(){});", 226 ExpectJsFail("chrome.windows.create({left: 'foo'}, function(){});",
221 "Uncaught Error: Invalid value for argument 0. Property " 227 "Uncaught Error: Invalid value for argument 0. Property "
222 "'left': Expected 'integer' but got 'string'."); 228 "'left': Expected 'integer' but got 'string'.");
223 ExpectJsFail("chrome.windows.create({top: 'foo'}, function(){});", 229 ExpectJsFail("chrome.windows.create({top: 'foo'}, function(){});",
224 "Uncaught Error: Invalid value for argument 0. Property " 230 "Uncaught Error: Invalid value for argument 0. Property "
225 "'top': Expected 'integer' but got 'string'."); 231 "'top': Expected 'integer' but got 'string'.");
226 ExpectJsFail("chrome.windows.create({width: 'foo'}, function(){});", 232 ExpectJsFail("chrome.windows.create({width: 'foo'}, function(){});",
(...skipping 498 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 731
726 ExpectJsFail("chrome.i18n.getMessage('name', [])", 732 ExpectJsFail("chrome.i18n.getMessage('name', [])",
727 "Uncaught Error: Invalid value for argument 1. Value does not " 733 "Uncaught Error: Invalid value for argument 1. Value does not "
728 "match any valid type choices."); 734 "match any valid type choices.");
729 735
730 ExpectJsFail("chrome.i18n.getMessage('name', ['p1', 'p2', 'p3', 'p4', 'p5', " 736 ExpectJsFail("chrome.i18n.getMessage('name', ['p1', 'p2', 'p3', 'p4', 'p5', "
731 "'p6', 'p7', 'p8', 'p9', 'p10'])", 737 "'p6', 'p7', 'p8', 'p9', 'p10'])",
732 "Uncaught Error: Invalid value for argument 1. Value does not " 738 "Uncaught Error: Invalid value for argument 1. Value does not "
733 "match any valid type choices."); 739 "match any valid type choices.");
734 } 740 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698