Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 27413002: [telemetry] Upload results to cloud storage. (Closed)

Created:
7 years, 2 months ago by shatch
Modified:
7 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[telemetry] Add an option --upload-results to store the html results in google storage. Would like to be able to use this from the perf try bot to store the html results of each submitted job. BUG= TEST=tools/perf/run_measurement -v --browser=release blink_perf third_party/WebKit/PerformanceTests/Bindings/typed-array-construct-from-typed.html --upload-results Example output: View online at http://storage.googleapis.com/chromium-telemetry/html-results/results-2013-10-15_16-05-23 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229612

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes from review. #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix pagerunnertest. #

Patch Set 5 : Fix unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M tools/telemetry/telemetry/page/html_page_measurement_results.py View 1 2 3 chunks +12 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/results_options.py View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
shatch
7 years, 2 months ago (2013-10-15 21:44:55 UTC) #1
dtu
https://codereview.chromium.org/27413002/diff/1/tools/telemetry/telemetry/page/html_page_measurement_results.py File tools/telemetry/telemetry/page/html_page_measurement_results.py (right): https://codereview.chromium.org/27413002/diff/1/tools/telemetry/telemetry/page/html_page_measurement_results.py#newcode112 tools/telemetry/telemetry/page/html_page_measurement_results.py:112: cloud_storage.Insert(cloud_storage.PUBLIC_BUCKET, file_hash, file_path) We're creating a new bucket for ...
7 years, 2 months ago (2013-10-15 21:49:53 UTC) #2
shatch
https://codereview.chromium.org/27413002/diff/1/tools/telemetry/telemetry/page/html_page_measurement_results.py File tools/telemetry/telemetry/page/html_page_measurement_results.py (right): https://codereview.chromium.org/27413002/diff/1/tools/telemetry/telemetry/page/html_page_measurement_results.py#newcode112 tools/telemetry/telemetry/page/html_page_measurement_results.py:112: cloud_storage.Insert(cloud_storage.PUBLIC_BUCKET, file_hash, file_path) On 2013/10/15 21:49:53, dtu wrote: > ...
7 years, 2 months ago (2013-10-15 21:59:37 UTC) #3
shatch
New snapshot uploaded. From discussion offline, uploaded the results to a directory html-results under chromium-telemetry, ...
7 years, 2 months ago (2013-10-15 23:11:53 UTC) #4
dtu
lgtm
7 years, 2 months ago (2013-10-16 01:30:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/27413002/22001
7 years, 2 months ago (2013-10-17 21:06:26 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-17 23:16:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/27413002/41001
7 years, 2 months ago (2013-10-17 23:23:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/27413002/41001
7 years, 2 months ago (2013-10-18 01:42:27 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=90180
7 years, 2 months ago (2013-10-18 19:42:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/27413002/41001
7 years, 2 months ago (2013-10-18 21:34:58 UTC) #11
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) app_list_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=90634
7 years, 2 months ago (2013-10-19 10:36:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/27413002/41001
7 years, 2 months ago (2013-10-19 15:21:06 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-19 18:36:00 UTC) #14
Message was sent while issue was closed.
Change committed as 229612

Powered by Google App Engine
This is Rietveld 408576698