tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py - Issue 27413002: [telemetry] Upload results to cloud storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

Issue 27413002: [telemetry] Upload results to cloud storage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/html_page_measurement_results.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

index 0308e2202432176ff1deca6123624e471c89b65d..5a0b8e28d90994b02c04c5137f508c3b3a24cef4 100644

--- a/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

@@ -48,7 +48,7 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

# Run the first time and verify the results are written to the HTML file.

results = DeterministicHtmlPageMeasurementResults(

- output_file, 'test_name', False, 'browser_type')

+ output_file, 'test_name', False, False, 'browser_type')

results.WillMeasurePage(test_page_set.pages[0])

results.Add('a', 'seconds', 3)

results.DidMeasurePage()

@@ -101,7 +101,7 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

# Run the second time and verify the results are appended to the HTML file.

output_file.seek(0)

results = DeterministicHtmlPageMeasurementResults(

- output_file, 'test_name', False, 'browser_type')

+ output_file, 'test_name', False, False, 'browser_type')

results.WillMeasurePage(test_page_set.pages[0])

results.Add('a', 'seconds', 4)

results.DidMeasurePage()

@@ -191,7 +191,7 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

# Now reset the results and verify the old ones are gone.

output_file.seek(0)

results = DeterministicHtmlPageMeasurementResults(

- output_file, 'test_name', True, 'browser_type')

+ output_file, 'test_name', True, False, 'browser_type')

results.WillMeasurePage(test_page_set.pages[0])

results.Add('a', 'seconds', 5)

results.DidMeasurePage()