When Chrome hands off a URL to be opened by the external host by the ViewHost...

When Chrome hands off a URL to be opened by the external host by the ViewHostMsg_OpenURL IPC, it
needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the
HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back.

The ChromeFrame changes are basically around the same lines with one exception. When we handle the
AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable
to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then
save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading
the referer and passing it off to Chrome in the NavigateInExternalTab message.

Added a unit test in ChromeFrame which tests this case.

This fixes http://code.google.com/p/chromium/issues/detail?id=22994

Bug=22994

[amit, 2009-10-16 00:15:12]

Looks pretty good.  I guess we need to go through different OpenUrl calls to see
if/what referrer should be specified. Also, it'd be good to get it right even
for the widget mode while it's still fresh in your mind :)

http://codereview.chromium.org/274071/diff/1/10
File chrome_frame/bho.cc (right):

http://codereview.chromium.org/274071/diff/1/10#newcode139
Line 139: while (it.GetNext()) {
Tommi is adding a find method to the iterator that would be handy here.

http://codereview.chromium.org/274071/diff/1/10#newcode245
Line 245: return bho_current_thread_instance_.Pointer()->Get();
A DCHECK maybe?

http://codereview.chromium.org/274071/diff/1/5
File chrome_frame/chrome_frame_activex_base.h (right):

http://codereview.chromium.org/274071/diff/1/5#newcode455
Line 455: OnOpenURL(tab_handle, GURL(url), GURL(), disposition);
Referrer is the original document url? What happens in the window.open case?

http://codereview.chromium.org/274071/diff/1/5#newcode523
Line 523: std::string(),
Maybe, the referrer here should be the containing document URL

http://codereview.chromium.org/274071/diff/1/11
File chrome_frame/chrome_frame_npapi.cc (right):

http://codereview.chromium.org/274071/diff/1/11#newcode1045
Line 1045: std::string(),
The referrer might have to be the containing document url.

http://codereview.chromium.org/274071/diff/1/11#newcode1315
Line 1315: std::string(),
Referrer maybe be one of the args?

[Paweł Hajdan Jr., 2009-10-16 05:16:56]

Drive by with a small nit to keep automation messages clean.

http://codereview.chromium.org/274071/diff/5001/2013
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/274071/diff/5001/2013#newcode436
Line 436: // The third parameter is the referrer
nit: Please add a dot at the end of the sentence.

[ananta, 2009-10-16 16:56:37]

http://codereview.chromium.org/274071/diff/1/10
File chrome_frame/bho.cc (right):

http://codereview.chromium.org/274071/diff/1/10#newcode139
Line 139: while (it.GetNext()) {
On 2009/10/16 00:15:12, amit wrote:
> Tommi is adding a find method to the iterator that would be handy here.

ok. I will change this once he submits his CL

http://codereview.chromium.org/274071/diff/1/10#newcode245
Line 245: return bho_current_thread_instance_.Pointer()->Get();
On 2009/10/16 00:15:12, amit wrote:
> A DCHECK maybe?

Done.

http://codereview.chromium.org/274071/diff/1/5
File chrome_frame/chrome_frame_activex_base.h (right):

http://codereview.chromium.org/274071/diff/1/5#newcode455
Line 455: OnOpenURL(tab_handle, GURL(url), GURL(), disposition);
On 2009/10/16 00:15:12, amit wrote:
> Referrer is the original document url? What happens in the window.open case?
In the window.open case the original document is set as the referrer. However it
does not matter here as window.open in Chrome creates the popup window and
navigates the popup internally. We don't handle it on the same lines as top
level url navigations.

http://codereview.chromium.org/274071/diff/1/5#newcode523
Line 523: std::string(),
On 2009/10/16 00:15:12, amit wrote:
> Maybe, the referrer here should be the containing document URL

Done.

http://codereview.chromium.org/274071/diff/1/11
File chrome_frame/chrome_frame_npapi.cc (right):

http://codereview.chromium.org/274071/diff/1/11#newcode1045
Line 1045: std::string(),
On 2009/10/16 00:15:12, amit wrote:
> The referrer might have to be the containing document url.

Done.

http://codereview.chromium.org/274071/diff/1/11#newcode1315
Line 1315: std::string(),
On 2009/10/16 00:15:12, amit wrote:
> Referrer maybe be one of the args?
Set it to the document URL.

http://codereview.chromium.org/274071/diff/5001/2013
File chrome/test/automation/automation_messages_internal.h (right):

http://codereview.chromium.org/274071/diff/5001/2013#newcode436
Line 436: // The third parameter is the referrer
On 2009/10/16 05:16:57, Paweł Hajdan Jr. wrote:
> nit: Please add a dot at the end of the sentence.

Done.

[amit, 2009-10-16 18:42:30]

lgtm