chrome/browser/extensions/extension_uitest.cc - Issue 274071: When Chrome hands off a URL to be opened by the external host by the ViewHost...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_uitest.cc

Issue 274071: When Chrome hands off a URL to be opened by the external host by the ViewHost... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_uitest.cc

===================================================================

--- chrome/browser/extensions/extension_uitest.cc (revision 29317)

+++ chrome/browser/extensions/extension_uitest.cc (working copy)

@@ -71,7 +71,7 @@

// so that the test can control when it gets loaded, and so that we test

// the intended behavior that tabs should be able to show extension pages

// (useful for development etc.)

- tab->NavigateInExternalTab(url);

+ tab->NavigateInExternalTab(url, GURL());

EXPECT_TRUE(proxy->WaitForMessage(action_max_timeout_ms()));

proxy->DestroyHostWindow();

« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »