Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3844)

Unified Diff: chrome/renderer/render_view.h

Issue 2740008: Make the RenderView destructor private. Given the weird placement of this and... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.h
===================================================================
--- chrome/renderer/render_view.h (revision 49273)
+++ chrome/renderer/render_view.h (working copy)
@@ -432,9 +432,6 @@
std::string* json_retval);
virtual WebKit::WebCookieJar* GetCookieJar();
- // Do not delete directly. This class is reference counted.
- virtual ~RenderView();
-
// Called when a plugin has crashed.
void PluginCrashed(const FilePath& plugin_path);
@@ -586,6 +583,9 @@
const WebPreferences& webkit_preferences,
int64 session_storage_namespace_id);
+ // Do not delete directly. This class is reference counted.
+ virtual ~RenderView();
+
// Initializes this view with the given parent and ID. The |routing_id| can be
// set to 'MSG_ROUTING_NONE' if the true ID is not yet known. In this case,
// CompleteInit must be called later with the true ID.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698