Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/renderer/render_view.h

Issue 2740008: Make the RenderView destructor private. Given the weird placement of this and... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_ 5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_
6 #define CHROME_RENDERER_RENDER_VIEW_H_ 6 #define CHROME_RENDERER_RENDER_VIEW_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 virtual void DidMovePlugin(const webkit_glue::WebPluginGeometry& move); 425 virtual void DidMovePlugin(const webkit_glue::WebPluginGeometry& move);
426 virtual void DidStartLoadingForPlugin(); 426 virtual void DidStartLoadingForPlugin();
427 virtual void DidStopLoadingForPlugin(); 427 virtual void DidStopLoadingForPlugin();
428 virtual void ShowModalHTMLDialogForPlugin( 428 virtual void ShowModalHTMLDialogForPlugin(
429 const GURL& url, 429 const GURL& url,
430 const gfx::Size& size, 430 const gfx::Size& size,
431 const std::string& json_arguments, 431 const std::string& json_arguments,
432 std::string* json_retval); 432 std::string* json_retval);
433 virtual WebKit::WebCookieJar* GetCookieJar(); 433 virtual WebKit::WebCookieJar* GetCookieJar();
434 434
435 // Do not delete directly. This class is reference counted.
436 virtual ~RenderView();
437
438 // Called when a plugin has crashed. 435 // Called when a plugin has crashed.
439 void PluginCrashed(const FilePath& plugin_path); 436 void PluginCrashed(const FilePath& plugin_path);
440 437
441 // Called to indicate that there are no matching search results. 438 // Called to indicate that there are no matching search results.
442 void ReportNoFindInPageResults(int request_id); 439 void ReportNoFindInPageResults(int request_id);
443 440
444 #if defined(OS_MACOSX) 441 #if defined(OS_MACOSX)
445 void RegisterPluginDelegate(WebPluginDelegateProxy* delegate); 442 void RegisterPluginDelegate(WebPluginDelegateProxy* delegate);
446 void UnregisterPluginDelegate(WebPluginDelegateProxy* delegate); 443 void UnregisterPluginDelegate(WebPluginDelegateProxy* delegate);
447 #endif 444 #endif
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 enum AutoFillAction { 576 enum AutoFillAction {
580 AUTOFILL_NONE, // No state set. 577 AUTOFILL_NONE, // No state set.
581 AUTOFILL_FILL, // Fill the AutoFill form data. 578 AUTOFILL_FILL, // Fill the AutoFill form data.
582 AUTOFILL_PREVIEW, // Preview the AutoFill form data. 579 AUTOFILL_PREVIEW, // Preview the AutoFill form data.
583 }; 580 };
584 581
585 explicit RenderView(RenderThreadBase* render_thread, 582 explicit RenderView(RenderThreadBase* render_thread,
586 const WebPreferences& webkit_preferences, 583 const WebPreferences& webkit_preferences,
587 int64 session_storage_namespace_id); 584 int64 session_storage_namespace_id);
588 585
586 // Do not delete directly. This class is reference counted.
587 virtual ~RenderView();
588
589 // Initializes this view with the given parent and ID. The |routing_id| can be 589 // Initializes this view with the given parent and ID. The |routing_id| can be
590 // set to 'MSG_ROUTING_NONE' if the true ID is not yet known. In this case, 590 // set to 'MSG_ROUTING_NONE' if the true ID is not yet known. In this case,
591 // CompleteInit must be called later with the true ID. 591 // CompleteInit must be called later with the true ID.
592 void Init(gfx::NativeViewId parent, 592 void Init(gfx::NativeViewId parent,
593 int32 opener_id, 593 int32 opener_id,
594 const RendererPreferences& renderer_prefs, 594 const RendererPreferences& renderer_prefs,
595 SharedRenderViewCounter* counter, 595 SharedRenderViewCounter* counter,
596 int32 routing_id); 596 int32 routing_id);
597 597
598 void UpdateURL(WebKit::WebFrame* frame); 598 void UpdateURL(WebKit::WebFrame* frame);
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
1241 1241
1242 PepperPluginDelegateImpl pepper_delegate_; 1242 PepperPluginDelegateImpl pepper_delegate_;
1243 1243
1244 // The action to take when receiving AutoFill data from the AutoFillManager. 1244 // The action to take when receiving AutoFill data from the AutoFillManager.
1245 AutoFillAction autofill_action_; 1245 AutoFillAction autofill_action_;
1246 1246
1247 DISALLOW_COPY_AND_ASSIGN(RenderView); 1247 DISALLOW_COPY_AND_ASSIGN(RenderView);
1248 }; 1248 };
1249 1249
1250 #endif // CHROME_RENDERER_RENDER_VIEW_H_ 1250 #endif // CHROME_RENDERER_RENDER_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698