Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: chrome/browser/gtk/certificate_viewer.cc

Issue 2733014: gtk: Certificate viewer should show both A-label and U-label for CN and SubjectAltName IDNs (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: clarify comment Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/certificate_viewer.cc
diff --git a/chrome/browser/gtk/certificate_viewer.cc b/chrome/browser/gtk/certificate_viewer.cc
index 779fe58e065b586ebfd28d57886464694937fc59..7a041c246675e078c57e257e088f7609c86d4041 100644
--- a/chrome/browser/gtk/certificate_viewer.cc
+++ b/chrome/browser/gtk/certificate_viewer.cc
@@ -284,7 +284,7 @@ void CertificateViewer::InitGeneralPage() {
l10n_util::GetStringUTF8(IDS_CERT_INFO_SUBJECT_GROUP));
AddKeyValue(table, row++,
l10n_util::GetStringUTF8(IDS_CERT_INFO_COMMON_NAME_LABEL),
- Stringize(CERT_GetCommonName(&cert->subject)));
+ psm::ProcessIDN(Stringize(CERT_GetCommonName(&cert->subject))));
AddKeyValue(table, row++,
l10n_util::GetStringUTF8(IDS_CERT_INFO_ORGANIZATION_LABEL),
Stringize(CERT_GetOrgName(&cert->subject)));
@@ -301,7 +301,7 @@ void CertificateViewer::InitGeneralPage() {
l10n_util::GetStringUTF8(IDS_CERT_INFO_ISSUER_GROUP));
AddKeyValue(table, row++,
l10n_util::GetStringUTF8(IDS_CERT_INFO_COMMON_NAME_LABEL),
- Stringize(CERT_GetCommonName(&cert->issuer)));
+ psm::ProcessIDN(Stringize(CERT_GetCommonName(&cert->issuer))));
AddKeyValue(table, row++,
l10n_util::GetStringUTF8(IDS_CERT_INFO_ORGANIZATION_LABEL),
Stringize(CERT_GetOrgName(&cert->issuer)));
« no previous file with comments | « chrome/browser/gtk/certificate_manager.cc ('k') | chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698