chrome/browser/gtk/certificate_manager.cc - Issue 2733014: gtk: Certificate viewer should show both A-label and U-label for CN and SubjectAltName IDNs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/certificate_manager.cc

Issue 2733014: gtk: Certificate viewer should show both A-label and U-label for CN and SubjectAltName IDNs (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: clarify comment Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/gtk/certificate_manager.cc

diff --git a/chrome/browser/gtk/certificate_manager.cc b/chrome/browser/gtk/certificate_manager.cc

index 5ce3543e7210181def3732423ad650db0ca479da..0b73ea47a91e5639973a34afc5cf39e7aa298865 100644

--- a/chrome/browser/gtk/certificate_manager.cc

+++ b/chrome/browser/gtk/certificate_manager.cc

@@ -249,7 +249,8 @@ void CertificatePage::PopulateTree(CERTCertList* cert_list) {

org_tree_map_iter = org_tree_map.insert(std::make_pair(org,

iter)).first;

}

- std::string name = Stringize(CERT_GetCommonName(&cert->subject));

+ std::string name = psm::ProcessIDN(

+ Stringize(CERT_GetCommonName(&cert->subject)));

if (name.empty() && cert->nickname) {

name = cert->nickname;

// Hack copied from mozilla: Cut off text before first :, which seems to

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/gtk/certificate_viewer.cc » ('j') | no next file with comments »