Adding a Find method to the HeadersIterator class....

Adding a Find method to the HeadersIterator class.

TEST=Run the HeadersIterator_Find test.
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29273

[amit, 2009-10-15 23:33:03]

Nice, I think we need a Rewind() method for the iterator to reset the position.
Maybe should also be modified to Find(..., bool rewind). Otherwise in the unit
test, find('foo') wouldn't work if done after Find('bar').

[tommi1, 2009-10-16 02:12:17]

Sure.  I don't mind adding a Reset() method.
In the test, I'm purposely searching for 'foo' before 'bar'.  I also made
sure to document this behavior for the Find() method.

On Thu, Oct 15, 2009 at 7:33 PM, <amit@chromium.org> wrote:

> Nice, I think we need a Rewind() method for the iterator to reset the
> position.
> Maybe should also be modified to Find(..., bool rewind). Otherwise in the
> unit
> test, find('foo') wouldn't work if done after Find('bar').
>
>
>
>
> http://codereview.chromium.org/273072
>

[eroman, 2009-10-16 03:22:21]

I suggest naming this "AdvanceTo()" instead of "Find()".

Otherwise LGTM.

[tommi (sloooow) - chröme, 2009-10-16 05:04:59]

done - changes uploaded, waiting for trybots

On Thu, Oct 15, 2009 at 11:22 PM, <eroman@chromium.org> wrote:

> I suggest naming this "AdvanceTo()" instead of "Find()".
>
> Otherwise LGTM.
>
>
> http://codereview.chromium.org/273072
>

[eroman, 2009-10-16 21:21:41]

Still LGTM