Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 273059: Official builds should be on the com.google.Chrome update product ID (Closed)

Created:
11 years, 2 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org
Visibility:
Public.

Description

Official builds should be on the com.google.Chrome update product ID, not com.google.Chrome.framework BUG=24836 TEST=After running Google Chrome.app, run ~/Library/Google/GoogleSoftwareUpdate/GoogleSoftwareUpdate.bundle/Contents/MacOS/ksadmin -p. You should see, at the very least, tickets for com.google.Keystone and com.google.Chrome, and they should appear to have valid data. You should not see any tickets for com.google.Chrome.framework. If you run ksadmin -l, you should not get any error output. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29033

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -192 lines) Patch
D build/mac/tweak_app_infoplist View 1 chunk +0 lines, -182 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +10 lines, -6 lines 0 comments Download
A + chrome/tools/build/mac/tweak_info_plist View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 2 months ago (2009-10-14 21:15:00 UTC) #1
TVL
11 years, 2 months ago (2009-10-14 21:26:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698