Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: chrome/tools/build/mac/tweak_info_plist

Issue 273059: Official builds should be on the com.google.Chrome update product ID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/mac/tweak_info_plist
===================================================================
--- chrome/tools/build/mac/tweak_info_plist (revision 29018)
+++ chrome/tools/build/mac/tweak_info_plist (working copy)
@@ -39,8 +39,8 @@
shift $(($OPTIND - 1))
# Make sure the branding argument was supplied.
-if [ $# -ne 1 ]; then
- echo "error: missing branding as an argument" >&2
+if [ $# -ne 2 ]; then
+ echo "usage: $0 [-b 1] [-k 1] [-s 1] BRANDING IDENTIFIER" >&2
exit 1
fi
@@ -62,6 +62,7 @@
TOP="${SRCROOT}/.."
BUILD_BRANDING=$1
+IDENTIFIER=$2
set -x
@@ -159,8 +160,7 @@
# Add or remove the Keystone keys (only supported in release builds).
if [ "${USE_KEYSTONE}" = "1" ] && [ "${CONFIGURATION}" = "Release" ] ; then
KEYSTONE_URL="https://tools.google.com/service/update2"
- KEYSTONE_APP_ID=$(defaults read "${TMP_INFO_PLIST_DEFAULTS}" \
- CFBundleIdentifier)
+ KEYSTONE_APP_ID="${IDENTIFIER}"
defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
KSVersion -string "${FULL_VERSION}"
defaults write "${TMP_INFO_PLIST_DEFAULTS}" KSProductID "${KEYSTONE_APP_ID}"
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698