Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Unified Diff: chrome/browser/sync/engine/syncer_unittest.cc

Issue 273058: Fix some warnings on Mac that are treated as errors:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncer_unittest.cc
===================================================================
--- chrome/browser/sync/engine/syncer_unittest.cc (revision 29024)
+++ chrome/browser/sync/engine/syncer_unittest.cc (working copy)
@@ -4344,8 +4344,6 @@
}
}
-namespace {
Fred 2009/10/15 00:21:05 Instead of removing these namespace clauses, just
Munjal (Google) 2009/10/15 00:32:51 I thought it's better to be consistent within the
-
class SyncerPositionUpdateTest : public SyncerTest {
public:
SyncerPositionUpdateTest() : next_update_id_(1), next_revision_(1) {}
@@ -4395,8 +4393,6 @@
DISALLOW_COPY_AND_ASSIGN(SyncerPositionUpdateTest);
};
-} // namespace
-
TEST_F(SyncerPositionUpdateTest, InOrderPositive) {
// Add a bunch of items in increasing order, starting with just positive
// position values.
@@ -4462,8 +4458,6 @@
ExpectLocalItemsInServerOrder();
}
-namespace {
-
class SyncerPositionTiebreakingTest : public SyncerTest {
public:
SyncerPositionTiebreakingTest()
@@ -4518,8 +4512,6 @@
DISALLOW_COPY_AND_ASSIGN(SyncerPositionTiebreakingTest);
};
-} // namespace
-
TEST_F(SyncerPositionTiebreakingTest, LowMidHigh) {
Add(low_id_);
Add(mid_id_);
« no previous file with comments | « chrome/browser/sync/engine/net/gaia_authenticator_unittest.cc ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698