Fix some warnings on Mac that are treated as errors:...

chrome/browser/sync/engine/syncer_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE entry.
 //
 // Syncer unit tests. Unfortunately a lot of these tests
 // are outdated and need to be reworked and updated.
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 4326 matching lines @@
     ASSERT_TRUE(tag_bob.GetName().value() == PSTR("update2"));
     // The old item should be unchanged.
     Entry hurdle(&trans, GET_BY_HANDLE, hurdle_handle);
     ASSERT_TRUE(hurdle.good());
     ASSERT_TRUE(!hurdle.Get(IS_DEL));
     ASSERT_TRUE(hurdle.Get(SINGLETON_TAG).empty());
     ASSERT_TRUE(hurdle.GetName().value() == PSTR("bob"));
   }
 }
 
-namespace {

[Fred, 2009/10/15 00:21:05]

Instead of removing these namespace clauses, just include the TEST_F into the
anonymous namespace; that should work unless there's a FRIEND_TEST for these
tests.

[Munjal (Google), 2009/10/15 00:32:51]

I thought it's better to be consistent within the file rather than putting
maximum things in anonymous namespace. If I put some TEST_F inside anonymous and
some outside based on what has FRIEND_TEST and what doesn't it will become
inconsistent within the same file.

-
 class SyncerPositionUpdateTest : public SyncerTest {
  public:
   SyncerPositionUpdateTest() : next_update_id_(1), next_revision_(1) {}
 
  protected:
   void ExpectLocalItemsInServerOrder() {
     if (position_map_.empty())
       return;
 
     ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
@@ skipping 29 matching lines @@
         PosMap::value_type(position, Id::CreateFromServerId(id)));
   }
  private:
   typedef multimap<int64, Id> PosMap;
   PosMap position_map_;
   int next_update_id_;
   int next_revision_;
   DISALLOW_COPY_AND_ASSIGN(SyncerPositionUpdateTest);
 };
 
-}  // namespace
-
 TEST_F(SyncerPositionUpdateTest, InOrderPositive) {
   // Add a bunch of items in increasing order, starting with just positive
   // position values.
   AddRootItemWithPosition(100);
   AddRootItemWithPosition(199);
   AddRootItemWithPosition(200);
   AddRootItemWithPosition(201);
   AddRootItemWithPosition(400);
 
   syncer_->SyncShare();
@@ skipping 45 matching lines @@
 
   syncer_->SyncShare();
   ExpectLocalItemsInServerOrder();
 
   AddRootItemWithPosition(-144);
 
   syncer_->SyncShare();
   ExpectLocalItemsInServerOrder();
 }
 
-namespace {
-
 class SyncerPositionTiebreakingTest : public SyncerTest {
  public:
   SyncerPositionTiebreakingTest()
       : low_id_(Id::CreateFromServerId("A")),
         mid_id_(Id::CreateFromServerId("M")),
         high_id_(Id::CreateFromServerId("Z")),
         next_revision_(1) {
     DCHECK(low_id_ < mid_id_);
     DCHECK(mid_id_ < high_id_);
     DCHECK(low_id_ < high_id_);
@@ skipping 34 matching lines @@
   // order.
   const Id low_id_;
   const Id mid_id_;
   const Id high_id_;
 
  private:
   int next_revision_;
   DISALLOW_COPY_AND_ASSIGN(SyncerPositionTiebreakingTest);
 };
 
-}  // namespace
-
 TEST_F(SyncerPositionTiebreakingTest, LowMidHigh) {
   Add(low_id_);
   Add(mid_id_);
   Add(high_id_);
   syncer_->SyncShare();
   ExpectLocalOrderIsByServerId();
 }
 
 TEST_F(SyncerPositionTiebreakingTest, LowHighMid) {
   Add(low_id_);
@@ skipping 32 matching lines @@
   Add(low_id_);
   Add(high_id_);
   syncer_->SyncShare();
   ExpectLocalOrderIsByServerId();
 }
 
 const SyncerTest::CommitOrderingTest
 SyncerTest::CommitOrderingTest::LAST_COMMIT_ITEM = {-1, TestIdFactory::root()};
 
 }  // namespace browser_sync