Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 273017: Move native_widget_types and gtk_native_view_id_manager from base/gfx to... (Closed)

Created:
11 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, jam, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Move native_widget_types and gtk_native_view_id_manager from base/gfx to app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28691

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -881 lines) Patch
M app/app.gyp View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M app/gfx/blit.h View 1 chunk +1 line, -1 line 0 comments Download
A + app/gfx/gtk_native_view_id_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + app/gfx/gtk_native_view_id_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + app/gfx/native_widget_types.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + app/gfx/native_widget_types_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + app/win/window_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + app/win/window_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
D base/gfx/gtk_native_view_id_manager.h View 1 chunk +0 lines, -91 lines 0 comments Download
D base/gfx/gtk_native_view_id_manager.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D base/gfx/native_widget_types.h View 1 chunk +0 lines, -143 lines 0 comments Download
D base/gfx/native_widget_types_gtk.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D base/window_impl.h View 1 chunk +0 lines, -110 lines 0 comments Download
D base/window_impl.cc View 1 chunk +0 lines, -213 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_window_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/blocked_popup_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/download_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/extension_view_mac.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dock_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dock_info_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/fonts_languages_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gears_integration.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_context_menu_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/download_shelf_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_view_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tab_contents_drag_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/input_window_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_info_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/edit_search_engine_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_dialogs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/blocked_popup_container_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_menu_controller_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/browser_dialogs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/confirm_message_box_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/repost_form_warning_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/native_view_photobooth.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common_param_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/native_window_notification_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/platform_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/platform_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/plugin_messages.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/npobject_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/npobject_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_channel_base.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_widget.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.h View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/memory_watcher/hotkey.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/button/native_button_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/combobox/native_combobox_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_2.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/menu_wrapper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/view_menu_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/native/native_view_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/slider/native_slider_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/textfield.h View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/focus_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M views/screen.h View 1 chunk +1 line, -1 line 0 comments Download
M views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/tooltip_manager_win.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/widget_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M views/window/window.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/plugin_impl_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/gtk_plugin_container_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webplugin.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webplugin_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webplugin_page_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/foreground_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 2 months ago (2009-10-10 22:12:52 UTC) #1
Ben Goodger (Google)
11 years, 2 months ago (2009-10-10 22:14:24 UTC) #2
OK.

On Sat, Oct 10, 2009 at 3:12 PM,  <brettw@chromium.org> wrote:
> Reviewers: Ben Goodger,
>
> Description:
> Move native_widget_types and gtk_native_view_id_manager from base/gfx to
> app/gfx in preparation for removing the base_gfx project. This also moves
> base/window_impl.cc to app/win/window_impl because this file shouldn't be=
 in
> base.
>
> TEST=3Dnone
> BUG=3Dnone
>
> Please review this at http://codereview.chromium.org/273017
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 app/app.gyp
> =A0M =A0 =A0 app/gfx/blit.h
> =A0A =A0+ =A0app/gfx/gtk_native_view_id_manager.h
> =A0A =A0+ =A0app/gfx/gtk_native_view_id_manager.cc
> =A0A =A0+ =A0app/gfx/native_widget_types.h
> =A0A =A0+ =A0app/gfx/native_widget_types_gtk.cc
> =A0A =A0+ =A0app/win/window_impl.h
> =A0A =A0+ =A0app/win/window_impl.cc
> =A0M =A0 =A0 base/base.gyp
> =A0D =A0 =A0 base/gfx/gtk_native_view_id_manager.h
> =A0D =A0 =A0 base/gfx/gtk_native_view_id_manager.cc
> =A0D =A0 =A0 base/gfx/native_widget_types.h
> =A0D =A0 =A0 base/gfx/native_widget_types_gtk.cc
> =A0D =A0 =A0 base/window_impl.h
> =A0D =A0 =A0 base/window_impl.cc
> =A0M =A0 =A0 chrome/browser/autocomplete/autocomplete_edit_view.h
> =A0M =A0 =A0 chrome/browser/automation/automation_window_tracker.h
> =A0M =A0 =A0 chrome/browser/automation/ui_controls.h
> =A0M =A0 =A0 chrome/browser/blocked_popup_container.h
> =A0M =A0 =A0 chrome/browser/bookmarks/bookmark_context_menu_controller.h
> =A0M =A0 =A0 chrome/browser/bookmarks/bookmark_drop_info.h
> =A0M =A0 =A0 chrome/browser/bookmarks/bookmark_editor.h
> =A0M =A0 =A0 chrome/browser/bookmarks/bookmark_utils.h
> =A0M =A0 =A0 chrome/browser/browser_uitest.cc
> =A0M =A0 =A0 chrome/browser/browser_window.h
> =A0M =A0 =A0 chrome/browser/cocoa/extension_view_mac.h
> =A0M =A0 =A0 chrome/browser/dock_info.h
> =A0M =A0 =A0 chrome/browser/dock_info_gtk.cc
> =A0M =A0 =A0 chrome/browser/download/download_file.h
> =A0M =A0 =A0 chrome/browser/download/download_util.h
> =A0M =A0 =A0 chrome/browser/extensions/extension_install_ui.h
> =A0M =A0 =A0 chrome/browser/first_run.h
> =A0M =A0 =A0 chrome/browser/fonts_languages_window.h
> =A0M =A0 =A0 chrome/browser/gears_integration.h
> =A0M =A0 =A0 chrome/browser/gtk/bookmark_context_menu_gtk.h
> =A0M =A0 =A0 chrome/browser/gtk/download_shelf_gtk.h
> =A0M =A0 =A0 chrome/browser/gtk/extension_view_gtk.h
> =A0M =A0 =A0 chrome/browser/gtk/tab_contents_container_gtk.cc
> =A0M =A0 =A0 chrome/browser/gtk/tab_contents_drag_source.h
> =A0M =A0 =A0 chrome/browser/importer/importer.h
> =A0M =A0 =A0 chrome/browser/input_window_dialog.h
> =A0M =A0 =A0 chrome/browser/page_info_window.h
> =A0M =A0 =A0 chrome/browser/plugin_process_host.h
> =A0M =A0 =A0 chrome/browser/plugin_process_host.cc
> =A0M =A0 =A0 chrome/browser/printing/print_job.h
> =A0M =A0 =A0 chrome/browser/process_singleton.h
> =A0M =A0 =A0 chrome/browser/renderer_host/render_view_host.cc
> =A0M =A0 =A0 chrome/browser/renderer_host/render_widget_host.h
> =A0M =A0 =A0 chrome/browser/renderer_host/render_widget_host_view.h
> =A0M =A0 =A0 chrome/browser/renderer_host/render_widget_host_view_gtk.h
> =A0M =A0 =A0 chrome/browser/renderer_host/resource_message_filter.h
> =A0M =A0 =A0 chrome/browser/renderer_host/resource_message_filter.cc
> =A0M =A0 =A0 chrome/browser/renderer_host/resource_message_filter_gtk.cc
> =A0M =A0 =A0 chrome/browser/search_engines/edit_search_engine_controller.=
h
> =A0M =A0 =A0 chrome/browser/search_engines/template_url_fetcher.h
> =A0M =A0 =A0 chrome/browser/shell_dialogs.h
> =A0M =A0 =A0 chrome/browser/tab_contents/tab_contents.h
> =A0M =A0 =A0 chrome/browser/tab_contents/tab_contents_delegate.h
> =A0M =A0 =A0 chrome/browser/tab_contents/tab_contents_view.h
> =A0M =A0 =A0 chrome/browser/tab_contents/web_drag_source.h
> =A0M =A0 =A0 chrome/browser/views/blocked_popup_container_view_win.h
> =A0M =A0 =A0 chrome/browser/views/bookmark_menu_controller_views.h
> =A0M =A0 =A0 chrome/browser/views/browser_dialogs.h
> =A0M =A0 =A0 chrome/browser/views/confirm_message_box_dialog.h
> =A0M =A0 =A0 chrome/browser/views/find_bar_host.h
> =A0M =A0 =A0 chrome/browser/views/frame/browser_view.h
> =A0M =A0 =A0 chrome/browser/views/repost_form_warning_view.h
> =A0M =A0 =A0 chrome/browser/views/tabs/native_view_photobooth.h
> =A0M =A0 =A0 chrome/common/common_param_traits.h
> =A0M =A0 =A0 chrome/common/native_window_notification_source.h
> =A0M =A0 =A0 chrome/common/platform_util.h
> =A0M =A0 =A0 chrome/common/platform_util_win.cc
> =A0M =A0 =A0 chrome/common/plugin_messages.h
> =A0M =A0 =A0 chrome/common/plugin_messages_internal.h
> =A0M =A0 =A0 chrome/common/render_messages.h
> =A0M =A0 =A0 chrome/common/render_messages_internal.h
> =A0M =A0 =A0 chrome/common/temp_scaffolding_stubs.h
> =A0M =A0 =A0 chrome/plugin/npobject_proxy.h
> =A0M =A0 =A0 chrome/plugin/npobject_stub.h
> =A0M =A0 =A0 chrome/plugin/plugin_channel_base.h
> =A0M =A0 =A0 chrome/renderer/render_thread.h
> =A0M =A0 =A0 chrome/renderer/render_view.cc
> =A0M =A0 =A0 chrome/renderer/render_widget.h
> =A0M =A0 =A0 chrome/renderer/webplugin_delegate_proxy.h
> =A0M =A0 =A0 chrome/renderer/webplugin_delegate_proxy.cc
> =A0M =A0 =A0 chrome/test/automation/automation_proxy.h
> =A0M =A0 =A0 chrome/test/automation/automation_proxy_uitest.h
> =A0M =A0 =A0 tools/memory_watcher/hotkey.h
> =A0M =A0 =A0 views/controls/button/native_button_wrapper.h
> =A0M =A0 =A0 views/controls/combobox/native_combobox_wrapper.h
> =A0M =A0 =A0 views/controls/menu/menu.h
> =A0M =A0 =A0 views/controls/menu/menu_2.h
> =A0M =A0 =A0 views/controls/menu/menu_win.cc
> =A0M =A0 =A0 views/controls/menu/menu_wrapper.h
> =A0M =A0 =A0 views/controls/menu/view_menu_delegate.h
> =A0M =A0 =A0 views/controls/native/native_view_host.h
> =A0M =A0 =A0 views/controls/scrollbar/native_scroll_bar_win.cc
> =A0M =A0 =A0 views/controls/slider/native_slider_wrapper.h
> =A0M =A0 =A0 views/controls/textfield/native_textfield_wrapper.h
> =A0M =A0 =A0 views/controls/textfield/textfield.h
> =A0M =A0 =A0 views/focus/focus_manager.h
> =A0M =A0 =A0 views/screen.h
> =A0M =A0 =A0 views/view.h
> =A0M =A0 =A0 views/widget/tooltip_manager_win.h
> =A0M =A0 =A0 views/widget/widget.h
> =A0M =A0 =A0 views/widget/widget_win.h
> =A0M =A0 =A0 views/window/window.h
> =A0M =A0 =A0 webkit/default_plugin/plugin_impl_win.h
> =A0M =A0 =A0 webkit/glue/plugins/gtk_plugin_container_manager.h
> =A0M =A0 =A0 webkit/glue/plugins/plugin_instance.h
> =A0M =A0 =A0 webkit/glue/plugins/webplugin_delegate_impl.h
> =A0M =A0 =A0 webkit/glue/webplugin.h
> =A0M =A0 =A0 webkit/glue/webplugin_delegate.h
> =A0M =A0 =A0 webkit/glue/webplugin_impl.h
> =A0M =A0 =A0 webkit/glue/webplugin_page_delegate.h
> =A0M =A0 =A0 webkit/tools/test_shell/foreground_helper.h
> =A0M =A0 =A0 webkit/tools/test_shell/test_shell.h
> =A0M =A0 =A0 webkit/tools/test_shell/test_webview_delegate.cc
> =A0M =A0 =A0 webkit/tools/test_shell/test_webview_delegate_win.cc
> =A0M =A0 =A0 webkit/tools/test_shell/webview_host.h
> =A0M =A0 =A0 webkit/tools/test_shell/webwidget_host.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698