Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2725003: Add parenthesis around '&&' within '||'... (Closed)

Created:
10 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add parenthesis around '&&' within '||' Warning by some gcc versions. Adding the parenthesis made the condition correct. TBR=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 6 months ago (2010-06-08 12:20:16 UTC) #1
Mads Ager (chromium)
10 years, 6 months ago (2010-06-08 12:21:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698