Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm/assembler-arm-inl.h

Issue 2725003: Add parenthesis around '&&' within '||'... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 void RelocInfo::Visit(ObjectVisitor* visitor) { 177 void RelocInfo::Visit(ObjectVisitor* visitor) {
178 RelocInfo::Mode mode = rmode(); 178 RelocInfo::Mode mode = rmode();
179 if (mode == RelocInfo::EMBEDDED_OBJECT) { 179 if (mode == RelocInfo::EMBEDDED_OBJECT) {
180 visitor->VisitPointer(target_object_address()); 180 visitor->VisitPointer(target_object_address());
181 } else if (RelocInfo::IsCodeTarget(mode)) { 181 } else if (RelocInfo::IsCodeTarget(mode)) {
182 visitor->VisitCodeTarget(this); 182 visitor->VisitCodeTarget(this);
183 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 183 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
184 visitor->VisitExternalReference(target_reference_address()); 184 visitor->VisitExternalReference(target_reference_address());
185 #ifdef ENABLE_DEBUGGER_SUPPORT 185 #ifdef ENABLE_DEBUGGER_SUPPORT
186 } else if (Debug::has_break_points() && 186 } else if (Debug::has_break_points() &&
187 (RelocInfo::IsJSReturn(mode) && 187 ((RelocInfo::IsJSReturn(mode) &&
188 IsPatchedReturnSequence()) || 188 IsPatchedReturnSequence()) ||
189 (RelocInfo::IsDebugBreakSlot(mode) && 189 (RelocInfo::IsDebugBreakSlot(mode) &&
190 IsPatchedDebugBreakSlotSequence())) { 190 IsPatchedDebugBreakSlotSequence()))) {
191 visitor->VisitDebugTarget(this); 191 visitor->VisitDebugTarget(this);
192 #endif 192 #endif
193 } else if (mode == RelocInfo::RUNTIME_ENTRY) { 193 } else if (mode == RelocInfo::RUNTIME_ENTRY) {
194 visitor->VisitRuntimeEntry(this); 194 visitor->VisitRuntimeEntry(this);
195 } 195 }
196 } 196 }
197 197
198 198
199 Operand::Operand(int32_t immediate, RelocInfo::Mode rmode) { 199 Operand::Operand(int32_t immediate, RelocInfo::Mode rmode) {
200 rm_ = no_reg; 200 rm_ = no_reg;
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 // CPU::FlushICache(pc, sizeof(target)); 300 // CPU::FlushICache(pc, sizeof(target));
301 // However, on ARM, no instruction was actually patched by the assignment 301 // However, on ARM, no instruction was actually patched by the assignment
302 // above; the target address is not part of an instruction, it is patched in 302 // above; the target address is not part of an instruction, it is patched in
303 // the constant pool and is read via a data access; the instruction accessing 303 // the constant pool and is read via a data access; the instruction accessing
304 // this address in the constant pool remains unchanged. 304 // this address in the constant pool remains unchanged.
305 } 305 }
306 306
307 } } // namespace v8::internal 307 } } // namespace v8::internal
308 308
309 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_ 309 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698