Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: chrome/browser/extensions/extension_unittest.cc

Issue 27248: Fixed a unittest that I missed during my previous id format change. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_unittest.cc
===================================================================
--- chrome/browser/extensions/extension_unittest.cc (revision 10537)
+++ chrome/browser/extensions/extension_unittest.cc (working copy)
@@ -170,16 +170,17 @@
// Test minimal extension
input_value.SetInteger(Extension::kFormatVersionKey, 1);
- input_value.SetString(Extension::kIdKey, "com.google.myextension");
+ input_value.SetString(Extension::kIdKey,
+ "00123456789ABCDEF0123456789ABCDEF0123456");
input_value.SetString(Extension::kVersionKey, "1.0.0.0");
input_value.SetString(Extension::kNameKey, "my extension");
EXPECT_TRUE(extension.InitFromValue(input_value, &error));
EXPECT_EQ("", error);
- EXPECT_EQ("com.google.myextension", extension.id());
+ EXPECT_EQ("00123456789ABCDEF0123456789ABCDEF0123456", extension.id());
EXPECT_EQ("1.0.0.0", extension.VersionString());
EXPECT_EQ("my extension", extension.name());
- EXPECT_EQ("chrome-extension://com.google.myextension/",
+ EXPECT_EQ("chrome-extension://00123456789abcdef0123456789abcdef0123456/",
extension.url().spec());
EXPECT_EQ(path.value(), extension.path().value());
}
@@ -193,7 +194,8 @@
Extension extension(path);
DictionaryValue input_value;
input_value.SetInteger(Extension::kFormatVersionKey, 1);
- input_value.SetString(Extension::kIdKey, "com.google.myextension");
+ input_value.SetString(Extension::kIdKey,
+ "00123456789ABCDEF0123456789ABCDEF0123456");
input_value.SetString(Extension::kVersionKey, "1.0.0.0");
input_value.SetString(Extension::kNameKey, "my extension");
EXPECT_TRUE(extension.InitFromValue(input_value, NULL));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698