Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/extensions/extension_unittest.cc

Issue 27248: Fixed a unittest that I missed during my previous id format change. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "chrome/browser/extensions/extension.h" 7 #include "chrome/browser/extensions/extension.h"
8 #include "chrome/common/chrome_paths.h" 8 #include "chrome/common/chrome_paths.h"
9 #include "chrome/common/json_value_serializer.h" 9 #include "chrome/common/json_value_serializer.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 FilePath path(FILE_PATH_LITERAL("C:\\foo")); 163 FilePath path(FILE_PATH_LITERAL("C:\\foo"));
164 #elif defined(OS_POSIX) 164 #elif defined(OS_POSIX)
165 FilePath path(FILE_PATH_LITERAL("/foo")); 165 FilePath path(FILE_PATH_LITERAL("/foo"));
166 #endif 166 #endif
167 Extension extension(path); 167 Extension extension(path);
168 std::string error; 168 std::string error;
169 DictionaryValue input_value; 169 DictionaryValue input_value;
170 170
171 // Test minimal extension 171 // Test minimal extension
172 input_value.SetInteger(Extension::kFormatVersionKey, 1); 172 input_value.SetInteger(Extension::kFormatVersionKey, 1);
173 input_value.SetString(Extension::kIdKey, "com.google.myextension"); 173 input_value.SetString(Extension::kIdKey,
174 "00123456789ABCDEF0123456789ABCDEF0123456");
174 input_value.SetString(Extension::kVersionKey, "1.0.0.0"); 175 input_value.SetString(Extension::kVersionKey, "1.0.0.0");
175 input_value.SetString(Extension::kNameKey, "my extension"); 176 input_value.SetString(Extension::kNameKey, "my extension");
176 177
177 EXPECT_TRUE(extension.InitFromValue(input_value, &error)); 178 EXPECT_TRUE(extension.InitFromValue(input_value, &error));
178 EXPECT_EQ("", error); 179 EXPECT_EQ("", error);
179 EXPECT_EQ("com.google.myextension", extension.id()); 180 EXPECT_EQ("00123456789ABCDEF0123456789ABCDEF0123456", extension.id());
180 EXPECT_EQ("1.0.0.0", extension.VersionString()); 181 EXPECT_EQ("1.0.0.0", extension.VersionString());
181 EXPECT_EQ("my extension", extension.name()); 182 EXPECT_EQ("my extension", extension.name());
182 EXPECT_EQ("chrome-extension://com.google.myextension/", 183 EXPECT_EQ("chrome-extension://00123456789abcdef0123456789abcdef0123456/",
183 extension.url().spec()); 184 extension.url().spec());
184 EXPECT_EQ(path.value(), extension.path().value()); 185 EXPECT_EQ(path.value(), extension.path().value());
185 } 186 }
186 187
187 TEST(ExtensionTest, GetResourceURLAndPath) { 188 TEST(ExtensionTest, GetResourceURLAndPath) {
188 #if defined(OS_WIN) 189 #if defined(OS_WIN)
189 FilePath path(FILE_PATH_LITERAL("C:\\foo")); 190 FilePath path(FILE_PATH_LITERAL("C:\\foo"));
190 #elif defined(OS_POSIX) 191 #elif defined(OS_POSIX)
191 FilePath path(FILE_PATH_LITERAL("/foo")); 192 FilePath path(FILE_PATH_LITERAL("/foo"));
192 #endif 193 #endif
193 Extension extension(path); 194 Extension extension(path);
194 DictionaryValue input_value; 195 DictionaryValue input_value;
195 input_value.SetInteger(Extension::kFormatVersionKey, 1); 196 input_value.SetInteger(Extension::kFormatVersionKey, 1);
196 input_value.SetString(Extension::kIdKey, "com.google.myextension"); 197 input_value.SetString(Extension::kIdKey,
198 "00123456789ABCDEF0123456789ABCDEF0123456");
197 input_value.SetString(Extension::kVersionKey, "1.0.0.0"); 199 input_value.SetString(Extension::kVersionKey, "1.0.0.0");
198 input_value.SetString(Extension::kNameKey, "my extension"); 200 input_value.SetString(Extension::kNameKey, "my extension");
199 EXPECT_TRUE(extension.InitFromValue(input_value, NULL)); 201 EXPECT_TRUE(extension.InitFromValue(input_value, NULL));
200 202
201 EXPECT_EQ(extension.url().spec() + "bar/baz.js", 203 EXPECT_EQ(extension.url().spec() + "bar/baz.js",
202 Extension::GetResourceURL(extension.url(), "bar/baz.js").spec()); 204 Extension::GetResourceURL(extension.url(), "bar/baz.js").spec());
203 EXPECT_EQ(extension.url().spec() + "baz.js", 205 EXPECT_EQ(extension.url().spec() + "baz.js",
204 Extension::GetResourceURL(extension.url(), "bar/../baz.js").spec()); 206 Extension::GetResourceURL(extension.url(), "bar/../baz.js").spec());
205 EXPECT_EQ(extension.url().spec() + "baz.js", 207 EXPECT_EQ(extension.url().spec() + "baz.js",
206 Extension::GetResourceURL(extension.url(), "../baz.js").spec()); 208 Extension::GetResourceURL(extension.url(), "../baz.js").spec());
207 209
208 EXPECT_EQ(path.Append(FILE_PATH_LITERAL("bar")) 210 EXPECT_EQ(path.Append(FILE_PATH_LITERAL("bar"))
209 .Append(FILE_PATH_LITERAL("baz.js")).value(), 211 .Append(FILE_PATH_LITERAL("baz.js")).value(),
210 Extension::GetResourcePath(extension.path(), "bar/baz.js").value()); 212 Extension::GetResourcePath(extension.path(), "bar/baz.js").value());
211 EXPECT_EQ(path.Append(FILE_PATH_LITERAL("baz.js")).value(), 213 EXPECT_EQ(path.Append(FILE_PATH_LITERAL("baz.js")).value(),
212 Extension::GetResourcePath(extension.path(), "bar/../baz.js") 214 Extension::GetResourcePath(extension.path(), "bar/../baz.js")
213 .value()); 215 .value());
214 EXPECT_EQ(FilePath().value(), 216 EXPECT_EQ(FilePath().value(),
215 Extension::GetResourcePath(extension.path(), "../baz.js").value()); 217 Extension::GetResourcePath(extension.path(), "../baz.js").value());
216 } 218 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698