Issue 2724010: Revert 49298 - Broke compile - Token-based authentication for chromoting....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2724010: Revert 49298 - Broke compile - Token-based authentication for chromoting.... (Closed)

Created:
10 years, 6 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 49298 - Broke compile - Token-based authentication for chromoting. BUG=none TEST=none Review URL: http://codereview.chromium.org/2749004 TBR=sergeyu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49300

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -246 lines)			Patch
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.h	View	1 chunk	+0 lines, -61 lines	0 comments	Download
D	chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc	View	1 chunk	+0 lines, -74 lines	0 comments	Download
M	chrome/common/net/notifier/communicator/single_login_attempt.cc	View	3 chunks	+87 lines, -1 line	0 comments	Download
M	remoting/base/constants.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	remoting/base/constants.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	remoting/chromoting.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	remoting/client/host_connection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/host_connection.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	remoting/client/simple_client.cc	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	remoting/host/simple_host.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/simple_host.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	remoting/host/simple_host_process.cc	View	2 chunks	+12 lines, -9 lines	0 comments	Download
M	remoting/jingle_glue/jingle_client.h	View	4 chunks	+6 lines, -13 lines	0 comments	Download
M	remoting/jingle_glue/jingle_client.cc	View	5 chunks	+20 lines, -29 lines	0 comments	Download
M	remoting/jingle_glue/jingle_test_client.cc	View	3 chunks	+9 lines, -8 lines	0 comments	Download
D	remoting/tools/gettoken.py	View	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

10 years, 6 months ago (2010-06-09 19:10:26 UTC) #2

In the future, please use the trybots before landing your CL.

Expand Messages | Collapse Messages