Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2749004: Token-based authentication for chromoting. (Closed)

Created:
10 years, 6 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Token-based authentication for chromoting. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49298 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49326

Patch Set 1 : -) #

Total comments: 4

Patch Set 2 : removed GetTlsServerInfo #

Patch Set 3 : - #

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -150 lines) Patch
chrome/chrome.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
M chrome/common/net/notifier/communicator/single_login_attempt.cc View 3 chunks +1 line, -87 lines 0 comments Download
M remoting/base/constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/base/constants.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/chromoting.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M remoting/client/host_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/host_connection.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/client/simple_client.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M remoting/host/simple_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/simple_host.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M remoting/host/simple_host_process.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M remoting/jingle_glue/jingle_client.h View 4 chunks +13 lines, -6 lines 0 comments Download
M remoting/jingle_glue/jingle_client.cc View 5 chunks +29 lines, -20 lines 0 comments Download
M remoting/jingle_glue/jingle_test_client.cc View 3 chunks +8 lines, -9 lines 0 comments Download
A remoting/tools/gettoken.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
Moved GaiaTokenPreXmppAuth to separate file and use it now in Chromoting.
10 years, 6 months ago (2010-06-08 20:44:07 UTC) #1
akalin
http://codereview.chromium.org/2749004/diff/11001/12002 File chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc (right): http://codereview.chromium.org/2749004/diff/11001/12002#newcode74 chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc:74: // TODO(akalin): remove this code. Remove this code per ...
10 years, 6 months ago (2010-06-08 21:16:00 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/2749004/diff/11001/12002 File chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc (right): http://codereview.chromium.org/2749004/diff/11001/12002#newcode74 chrome/common/net/notifier/communicator/gaia_token_pre_xmpp_auth.cc:74: // TODO(akalin): remove this code. On 2010/06/08 21:16:01, akalin ...
10 years, 6 months ago (2010-06-08 21:26:42 UTC) #3
Sergey Ulanov
ping
10 years, 6 months ago (2010-06-09 03:49:33 UTC) #4
akalin
On 2010/06/09 03:49:33, sergeyu wrote: > ping chrome/* stuff LGTM
10 years, 6 months ago (2010-06-09 06:21:38 UTC) #5
Alpha Left Google
10 years, 6 months ago (2010-06-09 18:28:47 UTC) #6 
LGTM on remoting/*.

Powered by Google App Engine
This is Rietveld 408576698