Issue 2722002: Fix a bug that causes input methods not to work in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2722002: Fix a bug that causes input methods not to work in Chrome. (Closed)

Created:
10 years, 6 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-os-reviews_chromium.org, Zachary Kuznia

Base URL:
ssh://git@gitrw.chromium.org//cros.git

Visibility:
Public.

Description

Fix a bug that causes input methods to malfunction in Chrome. As described in the comment in the code, we should not close the private connection, as it actually shares the same socket file descriptor with the regular IBus connection. BUG=3683 TEST=manually on the netbook

Patch Set 1 #

Total comments: 2

Patch Set 2 : rework comments #

Patch Set 3 : address comments #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	chromeos_input_method.cc	View	1 2	1 chunk	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

http://codereview.chromium.org/2722002/diff/1/2 File chromeos_input_method.cc (right): http://codereview.chromium.org/2722002/diff/1/2#newcode506 chromeos_input_method.cc:506: // module (im-ibus.so) will be closed, that causes input ...

10 years, 6 months ago (2010-06-08 12:11:23 UTC) #2

satorux1

10 years, 6 months ago (2010-06-08 12:19:27 UTC) #4

http://codereview.chromium.org/2722002/diff/1/2
File chromeos_input_method.cc (right):

http://codereview.chromium.org/2722002/diff/1/2#newcode506
chromeos_input_method.cc:506: // module (im-ibus.so) will be closed, that causes
input methods not
On 2010/06/08 12:11:23, Yusuke Sato wrote:
>  // module (im-ibus.so) and |ibus_| ?
> 

Done.

Expand Messages | Collapse Messages