Fix a bug that causes input methods not to work in Chrome.

chromeos_input_method.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos_input_method.h"
 
 #include <dbus/dbus-glib-lowlevel.h>  // for dbus_g_connection_get_connection.
 #include <ibus.h>
 
 #include <algorithm>  // for std::reverse.
@@ skipping 482 matching lines @@
   }
 
   ~InputMethodStatusConnection() {
     if (dbus_proxy_) {
       g_signal_handlers_disconnect_by_func(
           dbus_proxy_.gproxy(),
           reinterpret_cast<gpointer>(G_CALLBACK(DBusProxyDestroyCallback)),
           this);
     }
 
-    if (dbus_connection_.get()) {
-      // Close |dbus_connection_| since the connection is "private connection"
-      // and we know |this| is the only instance which uses the
-      // |dbus_connection_|. Otherwise, we may see an error message from dbus
-      // library like "The last reference on a connection was dropped without
-      // closing the connection."
-      DBusConnection* raw_connection = dbus_g_connection_get_connection(
-          dbus_connection_->g_connection());
-      if (raw_connection) {
-        dbus_connection_close(raw_connection);
-      }
-    }
+    // We don't close |dbus_connection_| since it actually shares the same
+    // socket file descriptor with the connection used in IBusBus. If we
+    // close |dbus_connection_| here, the connection used in the IBus IM
+    // module (im-ibus.so) and |ibus_| will also be closed, that causes
+    // input methods to malfunction in Chrome.
+    //
+    // Note that not closing |dbus_connection_| produces DBus warnings
+    // like below, but it's ok as warnings are not critical (See also
+    // crosbug.com/3596):
+    //
+    // The last reference on a connection was dropped without closing the
+    // connection.
 
     if (ibus_) {
       // Destruct IBus object.
       g_signal_handlers_disconnect_by_func(
           ibus_,
           reinterpret_cast<gpointer>(
               G_CALLBACK(IBusBusDisconnectedCallback)),
           this);
       g_signal_handlers_disconnect_by_func(
           ibus_,
@@ skipping 670 matching lines @@
     InputMethodStatusConnection* connection) {
   g_return_val_if_fail(connection, false);
   const bool is_connected = connection->ConnectionIsAlive();
   if (!is_connected) {
     LOG(WARNING) << "ChromeOSInputMethodStatusConnectionIsAlive: NOT alive";
   }
   return is_connected;
 }
 
 }  // namespace chromeos