Issue 2721009: Fix up the Windows omnibox after the recent endcap removal. This fixes most ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2721009: Fix up the Windows omnibox after the recent endcap removal. This fixes most ... (Closed)

Created:
10 years, 6 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix up the Windows omnibox after the recent endcap removal. This fixes most of the issues, but doesn't make the app launcher match the new style. BUG=45745 TEST=Omnibox has endcaps, insides are aligned and padded correctly, dropdown looks good Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49727

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -141 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/browser_theme_pack.cc	View	1	2 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc	View	1	5 chunks	+14 lines, -31 lines	0 comments	Download
M	chrome/browser/views/bubble_border.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bubble_border.cc	View	1	8 chunks	+42 lines, -49 lines	0 comments	Download
M	chrome/browser/views/location_bar/location_bar_view.h	View	1	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/views/location_bar/location_bar_view.cc	View	1	15 chunks	+74 lines, -45 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/2721009/diff/9001/10007 File chrome/browser/views/location_bar/location_bar_view.cc (right): http://codereview.chromium.org/2721009/diff/9001/10007#newcode550 chrome/browser/views/location_bar/location_bar_view.cc:550: static const SkScalar radius( Is it really worth ...

10 years, 6 months ago (2010-06-14 20:20:51 UTC) #2

Peter Kasting

10 years, 6 months ago (2010-06-14 20:22:16 UTC) #3

http://codereview.chromium.org/2721009/diff/9001/10007
File chrome/browser/views/location_bar/location_bar_view.cc (right):

http://codereview.chromium.org/2721009/diff/9001/10007#newcode550
chrome/browser/views/location_bar/location_bar_view.cc:550: static const
SkScalar radius(
On 2010/06/14 20:20:51, sky wrote:
> Is it really worth making this static?

Oops, I didn't mean to do that.

Expand Messages | Collapse Messages