Add FilePathTest.StripTrailingSeparator to base_unittests to test FilePath::StripTrailingSeparator

Add FilePathTest.StripTrailingSeparators to base_unittests to test
FilePath::StripTrailingSeparators.

BUG=24692
TEST=this

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28832

[Mark Mentovai, 2009-10-13 03:40:07]

http://codereview.chromium.org/272039

I don't have a Windows machine handy to test it on, so we'll see what
the try server says about this.

I wrote:
> StripTrailingSeparators is unfortunately one of the few parts of the
> FilePath API that doesn't have a unit test. =A0We should definitely fix
> this.
>
> When I initially wrote that code, it was not part of the public API,
> and was just an implementation detail used by BaseName and DirName,
> which were tested. =A0Somewhere along the line, StripTrailingSeparators
> became public. =A0That would have been the right time to add the tests.

[Erik does not do reviews, 2009-10-13 16:57:01]

LGTM

http://codereview.chromium.org/272039/diff/4002/5002
File base/file_path_unittest.cc (right):

http://codereview.chromium.org/272039/diff/4002/5002#newcode319
Line 319: { FPL("//"),            FPL("//") },
is this use case for windows network paths using / instead of \?

http://codereview.chromium.org/272039/diff/4002/5002#newcode334
Line 334: { FPL("c://"),          FPL("c://") },
just curious, what is this use case for?

[Mark Mentovai, 2009-10-13 17:25:47]

Erik Kay wrote:
> http://codereview.chromium.org/272039/diff/4002/5002
> File base/file_path_unittest.cc (right):
> 
> http://codereview.chromium.org/272039/diff/4002/5002#newcode319
> Line 319: { FPL("//"),            FPL("//") },
> is this use case for windows network paths using / instead of \?

That's one use.

Little-known fact: a double leading slash is actually part of the POSIX
standard.  The system is allowed to treat // as an alternate root.  Most don't,
but in case we ever come across a system that works this way, we need to handle
it properly.

See the top of file_path.h (where I wrote "Surprise!"),
http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03...,
and
http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_12
.

http://codereview.chromium.org/272039/diff/4002/5002#newcode334
> Line 334: { FPL("c://"),          FPL("c://") },
> just curious, what is this use case for?

Windows treats c:\\ the same way it treats \\.  This was intended to allow older
applications that require drive letters to support \\server\share\path, by
permitting c:\\server\share\path as an equivalent.  Since the OS treats these
paths specially, we need to do the same.  Since Windows can use either / or \ as
the separator, we treat c://, c:\\, //, and \\ all equivalently.

[Erik does not do reviews, 2009-10-13 17:30:45]

Neat.  Thanks for the info.  I was confident that these meant
something... I just didn't know what.

Erik


On Tue, Oct 13, 2009 at 10:25 AM,  <mark@chromium.org> wrote:
> Erik Kay wrote:
>>
>> http://codereview.chromium.org/272039/diff/4002/5002
>> File base/file_path_unittest.cc (right):
>
>> http://codereview.chromium.org/272039/diff/4002/5002#newcode319
>> Line 319: { FPL("//"), =A0 =A0 =A0 =A0 =A0 =A0FPL("//") },
>> is this use case for windows network paths using / instead of \?
>
> That's one use.
>
> Little-known fact: a double leading slash is actually part of the POSIX
> standard. =A0The system is allowed to treat // as an alternate root. =A0M=
ost
> don't,
> but in case we ever come across a system that works this way, we need to
> handle
> it properly.
>
> See the top of file_path.h (where I wrote "Surprise!"),
> http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#ta=
g_03_266,
> and
> http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#ta=
g_04_12
> .
>
> http://codereview.chromium.org/272039/diff/4002/5002#newcode334
>>
>> Line 334: { FPL("c://"), =A0 =A0 =A0 =A0 =A0FPL("c://") },
>> just curious, what is this use case for?
>
> Windows treats c:\\ the same way it treats \\. =A0This was intended to al=
low
> older
> applications that require drive letters to support \\server\share\path, b=
y
> permitting c:\\server\share\path as an equivalent. =A0Since the OS treats
> these
> paths specially, we need to do the same. =A0Since Windows can use either =
/ or
> \ as
> the separator, we treat c://, c:\\, //, and \\ all equivalently.
>
> http://codereview.chromium.org/272039
>