vboot_firmware/lib/cgptlib/cgptlib_internal.c - Issue 2718012: More cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vboot_firmware/lib/cgptlib/cgptlib_internal.c

Issue 2718012: More cleanup (Closed) Base URL: ssh://gitrw.chromium.org/vboot_reference.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: vboot_firmware/lib/cgptlib/cgptlib_internal.c

diff --git a/vboot_firmware/lib/cgptlib/cgptlib_internal.c b/vboot_firmware/lib/cgptlib/cgptlib_internal.c

index 0a4f46d5d36306a16e5fd430c93db8d39ac05f67..4f0229362520f47be5d2e086ee826fc59bf9fcf5 100644

--- a/vboot_firmware/lib/cgptlib/cgptlib_internal.c

+++ b/vboot_firmware/lib/cgptlib/cgptlib_internal.c

@@ -60,7 +60,7 @@ int CheckHeader(GptHeader *h, int is_secondary, uint64_t drive_sectors) {

if (h->reserved_zero)

return 1;

- /* TODO: Padding must be set to zero. */

+ /* Could check that padding is zero, but that doesn't matter to us. */

/* If entry size is different than our struct, we won't be able to

* parse it. Technically, any size 2^N where N>=7 is valid. */

« no previous file with comments | « vboot_firmware/lib/cgptlib/cgptlib.c ('k') | vboot_firmware/lib/cgptlib/include/cgptlib.h » ('j') | no next file with comments »