vboot_firmware/lib/cgptlib/cgptlib.c - Issue 2718012: More cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vboot_firmware/lib/cgptlib/cgptlib.c

Issue 2718012: More cleanup (Closed) Base URL: ssh://gitrw.chromium.org/vboot_reference.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: vboot_firmware/lib/cgptlib/cgptlib.c

diff --git a/vboot_firmware/lib/cgptlib/cgptlib.c b/vboot_firmware/lib/cgptlib/cgptlib.c

index 3c92384a3968e5991a1738c7a0d2f314703c84e0..4856311af363f9db9b26611d3c9d778938b1c829 100644

--- a/vboot_firmware/lib/cgptlib/cgptlib.c

+++ b/vboot_firmware/lib/cgptlib/cgptlib.c

@@ -95,7 +95,6 @@ int GptUpdateKernelEntry(GptData* gpt, uint32_t update_type) {

GptEntry* e = entries + gpt->current_kernel;

uint64_t previous_attr = e->attributes;

- /* TODO: need a better return code for these errors? */

if (gpt->current_kernel == CGPT_KERNEL_ENTRY_NOT_FOUND)

return GPT_ERROR_INVALID_UPDATE_TYPE;

if (!IsKernelEntry(e))

« no previous file with comments | « no previous file | vboot_firmware/lib/cgptlib/cgptlib_internal.c » ('j') | no next file with comments »