Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2589)

Unified Diff: samples/o3d-webgl/effect.js

Issue 2718003: Adding wireframe to the shadow map demo. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/o3d-webgl-samples/shadow-map.html ('k') | samples/o3djs/effect.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/o3d-webgl/effect.js
===================================================================
--- samples/o3d-webgl/effect.js (revision 49133)
+++ samples/o3d-webgl/effect.js (working copy)
@@ -430,10 +430,11 @@
var sasTypeName = sasTypes[name] || '';
var className = paramTypes[info.type] || '';
var numElements = 0; // TODO(petersont): Add array support.
- var semantic = semanticMap[name].semantic || o3d.Stream.UNKNOWN_SEMANTIC;
+ var semantic = (semanticMap[name] && semanticMap[name].semantic) ?
+ semanticMap[name].semantic : o3d.Stream.UNKNOWN_SEMANTIC;
- infoArray.push(new EffectParameterInfo(
- name, className, numElements, semantic, sasClassName));
+ infoArray.push(new o3d.EffectParameterInfo(
+ name, className, numElements, semantic, sasTypeName));
}
return infoArray;
« no previous file with comments | « samples/o3d-webgl-samples/shadow-map.html ('k') | samples/o3djs/effect.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698